Add deprecated functions and deprecation warnings #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulimoen
force-pushed
the
feature/versioned_functionality
branch
from
7647d1e to
796d3e5
Compare
aldanor
changed the title
aldanor
reviewed
Jul 4, 2021
aldanor
reviewed
Jul 4, 2021
|
Are we planning to go ahead with this? Will require a rebase if so. |
mulimoen
force-pushed
the
feature/versioned_functionality
branch
from
796d3e5 to
b494edb
Compare
|
I would like to see this included, it makes handling different versions of |
Closed
mulimoen
force-pushed
the
feature/versioned_functionality
branch
from
b494edb to
9dc87f7
Compare
|
Almost good to go! |
|
Have you left some review comments I can't see? |
aldanor
reviewed
Oct 6, 2021
Sorry I'm dumb, opened a pending a review and haven't submitted it :) There you go ^ |
|
And fixed! |
aldanor
approved these changes
Oct 6, 2021
|
Good to merge, thanks! 👍 (on to #157 next? will need another rebase) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the documentation and added all functions which were marked as deprecated, mostly for completeness of the bindings. Most of these functions were deprecated in 1.8.0, which is a version we don't support.
I've also fixed up the name of some structs to be consistent with the naming in 1.12.0, and made sure we have aliases for these to remain compatible with other supported versions.
Comments on objects are officially deprecated in favor of attributes. I've added the
deprecatedattribute on the set/clear_comment in the top crate.FIxes #114