-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removing it profile #63
Changes from 4 commits
b937503
c816279
8838319
de854d9
e7e55a7
ee9fcd7
8b1084a
67c73db
33f9740
29311bf
493648d
2432d85
c76dc05
02bea2b
0afb008
8820ee7
ed7487a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ | |
* It interacts with the components of the application using a componentClient | ||
* (already configured and provided automatically through injection). | ||
*/ | ||
public class IntegrationTest extends TestKitSupport { | ||
public class HelloWorldIT extends TestKitSupport { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can keep this as IMO, we should prefer suffixing the test with I understand that the folks from the fail failsafe plugin had to choose for But our parent pom configures the failsafe plugin and the surefire plugin. So we don't need to favor Then we have:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, my idea was to follow the convention but I think you make a valid point. It's for sure clearer. |
||
|
||
|
||
@Test | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,7 +51,7 @@ | |
import static org.assertj.core.api.Assertions.assertThat; | ||
|
||
@ExtendWith(Junit5LogCapturing.class) | ||
public class SdkIntegrationTest extends TestKitSupport { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's revert them all back to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Alright. |
||
public class SdkIT extends TestKitSupport { | ||
|
||
@Override | ||
protected TestKit.Settings testKitSettings() { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can change this to AKKA_TESTKIT_DEBUG, but later.