chore: removing it profile #63
Conversation
ci, parent pom and moving samples 'it' to 'test'
.github/workflows/ci.yml
Outdated
| @@ -440,7 +440,7 @@ jobs: | |||
| fi | |||
| if [ true == '${{matrix.it}}' ]; then | |||
| ${PRE_CMD} | |||
| KALIX_TESTKIT_DEBUG=true mvn verify -Pit --no-transfer-progress | |||
| KALIX_TESTKIT_DEBUG=true mvn verify --no-transfer-progress | |||
There was a problem hiding this comment.
we can change this to AKKA_TESTKIT_DEBUG, but later.
| @@ -11,7 +11,7 @@ | |||
| * It interacts with the components of the application using a componentClient | |||
| * (already configured and provided automatically through injection). | |||
| */ | |||
| public class IntegrationTest extends TestKitSupport { | |||
| public class HelloWorldIT extends TestKitSupport { | |||
There was a problem hiding this comment.
We can keep this as IntegrationTest because IntegrationTest is excluded from the mvn test. Also, HelloWorldIT is completely unrelated with the archetype.
IMO, we should prefer suffixing the test with IntegrationTest instead of IT in all cases because it makes it more obvious.
I understand that the folks from the fail failsafe plugin had to choose for IT, because they don't know where it will be used. So they needed to step out of *IntegrationTest to avoid conflicts with the more general *Test.
But our parent pom configures the failsafe plugin and the surefire plugin. So we don't need to favor IT.
Then we have:
*Testfor unit tests, picked by surefire.*IntegratrionTestare excluded.*IntegratrionTestand all the variants withIT(as originally define by failsafe plugin). Those will be picked by failsafe plugin.
There was a problem hiding this comment.
Ok, my idea was to follow the convention but I think you make a valid point. It's for sure clearer.
| @@ -51,7 +51,7 @@ | |||
| import static org.assertj.core.api.Assertions.assertThat; | |||
|
|
|||
| @ExtendWith(Junit5LogCapturing.class) | |||
| public class SdkIntegrationTest extends TestKitSupport { | |||
There was a problem hiding this comment.
Let's revert them all back to *IntegrationTest as per other comment.
There was a problem hiding this comment.
Alright.
Co-authored-by: Renato Cavalcanti <[email protected]>
Co-authored-by: Renato Cavalcanti <[email protected]>
Co-authored-by: Renato Cavalcanti <[email protected]>
Co-authored-by: Renato Cavalcanti <[email protected]>
Co-authored-by: Renato Cavalcanti <[email protected]>
.+ back to IntegrationTest suffix
This reverts commit 493648d.
This reverts commit 29311bf.
Bringing https://github.com/lightbend/akka-javasdk/pull/652
Changes