Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Default Transformtion should be identity in EventProducerPushDestination #1075

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix: Default Transformtion should be identity in EventProducerPushDestination #1075

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...c/src/main/scala/akka/projection/grpc/consumer/javadsl/EventProducerPushDestination.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ object EventProducerPushDestination {
new EventProducerPushDestination(
Optional.empty(),
acceptedStreamId,
(_, _) => Transformation.empty,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does emtpy do? Does it eat the event?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be a runtime exception telling you that you need to define some kind of transformation. empty is the starting point of the Transformation builder, then you register the actual transformations on that.

For these producer push events we have decided that it's not required to define a transformation.

(_, _) => Transformation.identity,
Optional.empty(),
Collections.emptyList(),
protobufDescriptors,
Expand Down