Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Default Transformtion should be identity in EventProducerPushDestination #1075

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix: Default Transformtion should be identity in EventProducerPushDestination #1075

merged 1 commit into from
Nov 28, 2023

Conversation

patriknw
Copy link
Member

  • that is what it is in scaladsl

octonato
octonato approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...grpc/src/main/scala/akka/projection/grpc/consumer/javadsl/EventProducerPushDestination.scala
@@ -58,7 +58,7 @@ object EventProducerPushDestination {
new EventProducerPushDestination(
Optional.empty(),
acceptedStreamId,
(_, _) => Transformation.empty,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does emtpy do? Does it eat the event?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be a runtime exception telling you that you need to define some kind of transformation. empty is the starting point of the Transformation builder, then you register the actual transformations on that.

For these producer push events we have decided that it's not required to define a transformation.

@johanandren johanandren merged commit b1d70fb into main Nov 28, 2023
20 checks passed
@johanandren johanandren deleted the wip-EventProducerPushDestination-patriknw branch November 28, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren approved these changes

@octonato octonato octonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patriknw @octonato @johanandren