-
Notifications
You must be signed in to change notification settings - Fork 688
New Bookmark Command #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
azaleacolburn
wants to merge
10
commits into
ajeetdsouza:main
Choose a base branch
from
azaleacolburn:bookmark-cmd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New Bookmark Command #1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: remove old bookmark dir fix: move stream test imports feat: bookmark completions
chore: remove old log
|
I don't like bookmark system. |
Contributor
Author
Discussions about the viability of bookmarking as a feature can be had in #1014. |
Closed
This was referenced Aug 10, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new subcommand called
bookmarkas per #1014Usage
zoxide bookmark foo ~/barcreates a bookmark in the database calledfoowhich aliases tobar.Then,
zoxide query fooautomatically outputs~/barbefore even opening aStream. However, it doesn't match, sozoxide query foooignores the bookmarking system and matchesdirsonfooo.This PR restructures the database, by turning
dirsinto a tuple containing the olddirs(a vector of directories) and a bookmarks hashmap. They must be under the same field so they can be serialized and deserialized together, while obeying theself_referencingstruct system.Warning
Because of this restructuring, old databases will no longer be deserializable.
However, this PR also adds additional code to the deserialize command, which will fall back on deserializing just the vector of
Dirs, then reserializing the database with those dirs and an empty hashmap.So existing zoxide instances should still operate perfectly, but old databases will be changed.