Skip to content

fix(tokens): correct --spectrum-cjk-font to reference --spectrum-cjk-font-family-stack #3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 10, 2025
Merged

fix(tokens): correct --spectrum-cjk-font to reference --spectrum-cjk-font-family-stack #3883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b6fd886
Update the value of --spectrum-cjk-font to reference --spectrum-cjk-f…
byteakp May 24, 2025
8e7e39b
fix(tokens): add changeset for CJK font variable fix
byteakp Jun 1, 2025
d5a8751
fix(tokens): add patch changeset for CJK font variable fix
byteakp Jun 1, 2025
6317077
Remove out-of-scope changes to .gitignore and .vscode files
byteakp Jun 6, 2025
aebae75
Revert out-of-scope changes to .gitignore
byteakp Jun 6, 2025
059620a
Revert unintended deletion of .gitignore and settings
byteakp Jun 7, 2025
d44c9bd
chore: remove unrelated updates from PR
castastrophe Jun 10, 2025
c75ef92
chore: revert regression in vscode settings
castastrophe Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/late-teams-share.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@spectrum-css/tokens": patch
---

Fixed --spectrum-cjk-font variable to correctly reference --spectrum-cjk-font-family-stack instead of --spectrum-code-font-family-stack
2 changes: 1 addition & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,5 +184,5 @@
".storybook/deprecated/*/*.mdx",
"components/*/stories/*.stories.js",
"components/*/stories/*.mdx"
]
]
}
2 changes: 1 addition & 1 deletion tokens/custom/global-vars.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
--spectrum-font-size: var(--spectrum-font-size-100);

--spectrum-cjk-font-family-stack: adobe-clean-han-japanese, var(--spectrum-cjk-font-family), sans-serif;
--spectrum-cjk-font: var(--spectrum-code-font-family-stack);
--spectrum-cjk-font: var(--spectrum-cjk-font-family-stack);

/* static white / black background color for docs containers */
--spectrum-docs-static-white-background-color: rgb(15 121 125);
Expand Down
Loading