Skip to content

fix(tokens): correct --spectrum-cjk-font to reference --spectrum-cjk-font-family-stack #3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 10, 2025

Conversation

byteakp
Copy link
Contributor

@byteakp byteakp commented Jun 1, 2025

This PR fixes a bug where the --spectrum-cjk-font variable incorrectly referenced --spectrum-code-font-family-stack. It now correctly points to --spectrum-cjk-font-family-stack, which is intended for CJK (Chinese, Japanese, Korean) font rendering.

Related Issue: Fixes #3793

Changes Made:

  • Updated --spectrum-cjk-font in tokens/custom/global-vars.css to reference the correct font family stack
  • Added changeset for proper version management

## How and where has this been tested?
  • @byteakp - Verified that the --spectrum-cjk-font now correctly inherits the CJK font stack
  • @byteakp - Ensured no visual regressions occur in components using this variable
  • @byteakp - Confirmed variable resolves correctly in the compiled CSS

## Validation steps
  • @byteakp - Opened components using --spectrum-cjk-font and validated font stack reflects CJK-specific fonts
  • @byteakp - Confirmed overall styling remains consistent

## Regression testing

Validate:

  • @byteakp - At least two documentation pages render correctly and are responsive
  • @byteakp - All components continue to load and render properly
  • VRTs have been run and reviewed (pending reviewer approval)

## To-do list
  • I have read the contribution guidelines
  • I have updated relevant storybook stories and templates (N/A for this change)

Copy link

changeset-bot bot commented Jun 1, 2025

🦋 Changeset detected

Latest commit: c75ef92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@spectrum-css/tokens Patch
@spectrum-css/preview Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@byteakp
Copy link
Contributor Author

byteakp commented Jun 1, 2025

Hi @castastrophe, I've incorporated all requested changes and added a Changeset as advised. The font reference has been corrected to --spectrum-cjk-font-family-stack, tested across components, and regression checks look good. Please review when you get a chance—thanks again!

@castastrophe castastrophe added bug Results from a bug in the CSS implementation size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. labels Jun 5, 2025
@castastrophe castastrophe force-pushed the fix-spectrum-cjk-font branch from afdcdc0 to 56e45df Compare June 5, 2025 17:57
@byteakp byteakp force-pushed the fix-spectrum-cjk-font branch from 56e45df to 2ea7240 Compare June 6, 2025 08:09
@castastrophe castastrophe force-pushed the fix-spectrum-cjk-font branch from f275dc7 to 059620a Compare June 10, 2025 21:38
Copy link
Collaborator

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the unrelated code as suggestions in the PR and I can batch update those so we can get this PR merged for you.

@castastrophe castastrophe enabled auto-merge (squash) June 10, 2025 21:44
@castastrophe
Copy link
Collaborator

A note, we expect the checks to fail here because it's not set up to run against branches in other scopes (only forks), but I've validated this locally.

@castastrophe castastrophe disabled auto-merge June 10, 2025 21:47
@castastrophe castastrophe merged commit 4e3a120 into adobe:main Jun 10, 2025
11 of 22 checks passed
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
@byteakp
Copy link
Contributor Author

byteakp commented Jun 11, 2025

Hey @castastrophe
Thanks a lot for helping get this PR across the line! Learned a lot through your suggestions 🙌

Would love to keep contributing — let me know if there’s anything else I could help with next 😊

Cheers!
@byteakp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Results from a bug in the CSS implementation size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--spectrum-cjk-font refers to --spectrum-code-font-family-stack
2 participants