-
Notifications
You must be signed in to change notification settings - Fork 201
fix(tokens): correct --spectrum-cjk-font to reference --spectrum-cjk-font-family-stack #3883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: c75ef92 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @castastrophe, I've incorporated all requested changes and added a Changeset as advised. The font reference has been corrected to |
afdcdc0
to
56e45df
Compare
56e45df
to
2ea7240
Compare
…ont-family-stack.
f275dc7
to
059620a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the unrelated code as suggestions in the PR and I can batch update those so we can get this PR merged for you.
A note, we expect the checks to fail here because it's not set up to run against branches in other scopes (only forks), but I've validated this locally. |
Hey @castastrophe — Would love to keep contributing — let me know if there’s anything else I could help with next 😊 Cheers! |
This PR fixes a bug where the --spectrum-cjk-font variable incorrectly referenced --spectrum-code-font-family-stack. It now correctly points to --spectrum-cjk-font-family-stack, which is intended for CJK (Chinese, Japanese, Korean) font rendering.
Related Issue: Fixes #3793
Changes Made:
--spectrum-cjk-font
intokens/custom/global-vars.css
to reference the correct font family stackValidate: