upcoming schedule setting: move setting to modal #4164

matt-fidd · 2025-01-16T09:50:02Z

From feedback issue:

moved the setting to the bottom of the schedules page
used a secondary button
moved into a modal to avoid the layout shift

I've also moved from "Edit" to "Change" terminology, it feels more natural

netlify · 2025-01-16T09:50:22Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`c920e9a`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/6788dc3c7602470008c33063
😎 Deploy Preview	https://deploy-preview-4164.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2025-01-16T09:51:30Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
13	6.02 MB → 6.02 MB (-2.6 kB)	-0.04%

Changeset

File	Δ	Size
`src/components/schedules/UpcomingLength.tsx`	🆕 +2.35 kB	0 B → 2.35 kB
`src/components/schedules/index.tsx`	📈 +441 B (+12.00%)	3.59 kB → 4.02 kB
`src/components/Modals.tsx`	📈 +120 B (+0.70%)	16.77 kB → 16.88 kB
`src/components/settings/Upcoming.tsx`	🔥 -3.18 kB (-100%)	3.18 kB → 0 B
`src/components/common/InfoBubble.tsx`	🔥 -1.75 kB (-100%)	1.75 kB → 0 B
`src/icons/v2/InformationCircle.tsx`	🔥 -580 B (-100%)	580 B → 0 B

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/index.js	3.78 MB → 3.78 MB (+2.47 kB)	+0.06%

Smaller

Asset	File Size	% Changed
static/js/wide.js	106.04 kB → 100.98 kB (-5.06 kB)	-4.78%

Unchanged

Asset	File Size	% Changed
static/js/useAccountPreviewTransactions.js	1.63 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/AppliedFilters.js	10.21 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/en-GB.js	96.9 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/en.js	96.91 kB	0%
static/js/narrow.js	84.3 kB	0%
static/js/uk.js	120.47 kB	0%
static/js/ReportRouter.js	1.59 MB	0%

github-actions · 2025-01-16T09:51:31Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.33 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.33 MB	0%

coderabbitai · 2025-01-16T10:13:54Z

Walkthrough

This pull request introduces a new feature for managing the length of upcoming scheduled transactions. It adds a new UpcomingLength component that enables users to select how far in advance they want to view scheduled transactions. The implementation includes a new modal type for 'schedules-upcoming-length', the removal of the previous UpcomingLengthSettings component, and the integration of a feature-flagged button in the schedules view to access this new modal. The changes involve multiple files across the desktop client and core state types to support this functionality, ensuring that the overall structure and logic of modal rendering remain intact.

Possibly related PRs

Add Upcoming length adjustment feature flag #3651: Introduces a feature flag for the upcoming length adjustment feature, which is directly related to the changes made in the main PR that adds the UpcomingLength component and its integration into the modal rendering logic.
[WIP] Add info text to Upcoming Length control #3639: Modifies the UpcomingLengthSettings component to include an information bubble and checks for the feature flag, aligning with the main PR's focus on the UpcomingLength component and its modal integration.
Move help-related items under one single menu #3648: Adds a feature flag mechanism to conditionally render UI elements, relevant as the main PR also introduces a new modal type that may depend on feature flags.

Suggested labels

sparkles: Merged

Suggested reviewers

youngcw
MikesGlitch

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 70664de and c920e9a.

📒 Files selected for processing (1)

packages/desktop-client/src/components/schedules/UpcomingLength.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/desktop-client/src/components/schedules/UpcomingLength.tsx

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: build (windows-latest)
GitHub Check: build (ubuntu-latest)
GitHub Check: Wait for Netlify build to finish

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/desktop-client/src/components/schedules/UpcomingLength.tsx (1)

1-1: Consider enabling TypeScript strict mode.

The @ts-strict-ignore comment suggests TypeScript strict mode issues. Consider addressing these issues to improve type safety.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b1627d7 and 70664de.

⛔ Files ignored due to path filters (1)

upcoming-release-notes/4164.md is excluded by !**/*.md

📒 Files selected for processing (5)

packages/desktop-client/src/components/Modals.tsx (2 hunks)
packages/desktop-client/src/components/schedules/UpcomingLength.tsx (1 hunks)
packages/desktop-client/src/components/schedules/index.tsx (4 hunks)
packages/desktop-client/src/components/settings/Upcoming.tsx (0 hunks)
packages/loot-core/src/client/state-types/modals.d.ts (1 hunks)

💤 Files with no reviewable changes (1)

packages/desktop-client/src/components/settings/Upcoming.tsx

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: Visual regression
GitHub Check: Functional
GitHub Check: build (macos-latest)
GitHub Check: build (windows-latest)
GitHub Check: build (ubuntu-latest)

🔇 Additional comments (8)

packages/desktop-client/src/components/schedules/UpcomingLength.tsx (2)

13-27: LGTM! Well-structured custom hook.

The useUpcomingLengthOptions hook is well-implemented with:

Clear type definitions using SyncedPrefs

Internationalized labels using useTranslation

Logical time period options

29-81: LGTM! Well-structured modal component.

The UpcomingLength component is well-implemented with:

Clear default value handling

Informative user guidance

Proper modal structure with header and close button

Accessible select input for time period selection

packages/desktop-client/src/components/schedules/index.tsx (3)

26-26: LGTM! Proper feature flag usage.

Good use of feature flag to control the rollout of the upcoming length adjustment feature.

43-45: LGTM! Clean callback implementation.

The onChangeUpcomingLength callback is well-implemented using useCallback for performance optimization.

127-142: LGTM! Clean UI implementation.

The UI changes are well-structured:

Proper use of flexbox for layout

Consistent gap spacing

Conditional rendering based on feature flag

packages/loot-core/src/client/state-types/modals.d.ts (1)

184-184: LGTM! Clean type definition.

The modal type is correctly defined with null options, consistent with other similar modals in the file.

packages/desktop-client/src/components/Modals.tsx (2)

77-77: LGTM! Clean import.

The import statement is properly placed with other schedule-related imports.

377-379: LGTM! Clean modal implementation.

The modal case is well-implemented:

Consistent with other modal cases

Properly passes key prop

Clean and minimal implementation

matt-fidd added 2 commits January 16, 2025 09:47

upcoming schedule setting: move setting to modal

fdd8769

note

8b5cf18

actual-github-bot bot changed the title ~~Upcoming/modal~~ [WIP] Upcoming/modal Jan 16, 2025

actual-github-bot bot added the 🚧 WIP label Jan 16, 2025

matt-fidd changed the title ~~[WIP] Upcoming/modal~~ [WIP] upcoming schedule setting: move setting to modal Jan 16, 2025

matt-fidd mentioned this pull request Jan 16, 2025

[Feedback] Scheduled transaction upcoming length adjustment #3660

Closed

change nomenclature

70664de

matt-fidd changed the title ~~[WIP] upcoming schedule setting: move setting to modal~~ upcoming schedule setting: move setting to modal Jan 16, 2025

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Jan 16, 2025

coderabbitai bot reviewed Jan 16, 2025

View reviewed changes

remove strict override

c920e9a

matt-fidd force-pushed the upcoming/modal branch from a54225e to c920e9a Compare January 16, 2025 10:15

youngcw approved these changes Jan 16, 2025

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Jan 16, 2025

matt-fidd merged commit b831d15 into actualbudget:master Jan 16, 2025
20 checks passed

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Jan 16, 2025

matt-fidd deleted the upcoming/modal branch January 16, 2025 15:13

youngcw mentioned this pull request Jan 16, 2025

enhance: add ability to control category learning per payee and globally #4081

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upcoming schedule setting: move setting to modal #4164

upcoming schedule setting: move setting to modal #4164

matt-fidd commented Jan 16, 2025 •

edited

Loading

netlify bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

coderabbitai bot commented Jan 16, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

upcoming schedule setting: move setting to modal #4164

upcoming schedule setting: move setting to modal #4164

Conversation

matt-fidd commented Jan 16, 2025 • edited Loading

netlify bot commented Jan 16, 2025 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Jan 16, 2025 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Jan 16, 2025 • edited Loading

Bundle Stats — loot-core

coderabbitai bot commented Jan 16, 2025 • edited Loading

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

matt-fidd commented Jan 16, 2025 •

edited

Loading

netlify bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

coderabbitai bot commented Jan 16, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)