release schedule upcoming length adjustment #4173

matt-fidd · 2025-01-16T21:26:10Z

matt-fidd · 2025-01-16T21:26:17Z

/update-vrt

netlify · 2025-01-16T21:27:19Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`62db966`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67897cc9cb55660008bcce63
😎 Deploy Preview	https://deploy-preview-4173.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2025-01-16T21:27:39Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
13	6.43 MB → 6.43 MB (-385 B)	-0.01%

Changeset

File	Δ	Size
`node_modules/clsx/dist/clsx.js`	🆕 +509 B	0 B → 509 B
`node_modules/clsx/dist/clsx.js?commonjs-module`	🆕 +27 B	0 B → 27 B
`node_modules/react-grid-layout/build/ReactGridLayout.js`	📉 -1 B (-0.00%)	24.96 kB → 24.96 kB
`node_modules/react-grid-layout/build/GridItem.js`	📉 -1 B (-0.00%)	21.49 kB → 21.49 kB
`node_modules/react-grid-layout/build/components/WidthProvider.js`	📉 -1 B (-0.02%)	5.22 kB → 5.22 kB
`src/components/schedules/index.tsx`	📉 -101 B (-2.45%)	4.02 kB → 3.92 kB
`src/components/settings/Experimental.tsx`	📉 -350 B (-8.23%)	4.16 kB → 3.81 kB
`src/hooks/useFeatureFlag.ts`	📉 -35 B (-9.80%)	357 B → 322 B
`node_modules/clsx/dist/clsx.mjs`	🔥 -368 B (-100%)	368 B → 0 B
`node_modules/clsx/dist/clsx.mjs?commonjs-proxy`	🔥 -64 B (-100%)	64 B → 0 B

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset	File Size	% Changed
static/js/index.js	4.19 MB → 4.19 MB (-217 B)	-0.00%
static/js/wide.js	100.99 kB → 100.89 kB (-101 B)	-0.10%
static/js/ReportRouter.js	1.59 MB → 1.59 MB (-67 B)	-0.00%

Unchanged

Asset	File Size	% Changed
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/useAccountPreviewTransactions.js	1.63 kB	0%
static/js/AppliedFilters.js	10.21 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/en.js	96.91 kB	0%
static/js/narrow.js	84.3 kB	0%
static/js/uk.js	120.47 kB	0%
static/js/en-GB.js	96.9 kB	0%

github-actions · 2025-01-16T21:27:40Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.33 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.33 MB	0%

coderabbitai · 2025-01-16T21:43:47Z

Walkthrough

The pull request involves removing the feature flag upcomingLengthAdjustment from multiple components and configuration files. The changes span across several files in the desktop client, including the schedules component, experimental settings, feature flag hook, and type definitions. The modifications remove the conditional rendering of the upcoming length adjustment feature, effectively making it a permanent part of the application's interface. The changes simplify the codebase by eliminating feature flag checks related to the upcoming length adjustment functionality.

Possibly related PRs

Add Upcoming length adjustment feature flag #3651: Introduces the original feature flag for upcomingLengthAdjustment
upcoming schedule setting: move setting to modal #4164: Moves upcoming length setting to a modal
make one month schedule upcoming length dynamic and add current month option #4168: Makes schedule upcoming length dynamic and adds current month option

Suggested labels

merged, feature-removal, cleanup

Suggested reviewers

youngcw
matt-fidd

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf360ad and 62db966.

⛔ Files ignored due to path filters (16)

packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-checks-the-page-visuals-1-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-checks-the-page-visuals-2-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-checks-the-page-visuals-3-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-1-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-10-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-11-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-12-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-13-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-14-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-15-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-2-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-3-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-4-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-5-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-6-chromium-linux.png is excluded by !**/*.png
upcoming-release-notes/4173.md is excluded by !**/*.md

📒 Files selected for processing (4)

packages/desktop-client/src/components/schedules/index.tsx (1 hunks)
packages/desktop-client/src/components/settings/Experimental.tsx (0 hunks)
packages/desktop-client/src/hooks/useFeatureFlag.ts (0 hunks)
packages/loot-core/src/types/prefs.d.ts (0 hunks)

💤 Files with no reviewable changes (3)

packages/loot-core/src/types/prefs.d.ts
packages/desktop-client/src/hooks/useFeatureFlag.ts
packages/desktop-client/src/components/settings/Experimental.tsx

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: Functional
GitHub Check: Visual regression
GitHub Check: build (windows-latest)
GitHub Check: build (ubuntu-latest)

🔇 Additional comments (1)

packages/desktop-client/src/components/schedules/index.tsx (1)

134-136: LGTM! Verify modal integration.

The button implementation looks good and aligns well with the UI. Since this was previously behind a feature flag, please verify that:

The 'schedules-upcoming-length' modal is properly implemented

The feature works correctly without the flag

✅ Verification successful

Modal implementation verified and complete

The modal component is properly implemented with all necessary functionality:

Correct modal registration with matching identifier

Complete state management using synchronized preferences

Clear user interface with proper translations

Feature flag successfully removed
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify the modal implementation exists and the feature works without the flag

# Check for modal implementation
rg -l "schedules-upcoming-length"

# Check for any remaining feature flag references
rg "upcomingLengthAdjustment"
Length of output: 294

Script:
#!/bin/bash
# Check modal type definition and implementation
ast-grep --pattern 'type $_ = {
  $$$
  "schedules-upcoming-length"$$$
}' 

# Check modal component implementation
cat packages/desktop-client/src/components/schedules/UpcomingLength.tsx

# Check modal registration in Modals.tsx
ast-grep --pattern '"schedules-upcoming-length": $_'
Length of output: 2498

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

actual-github-bot bot changed the title ~~release schedule upcoming length adjustment~~ [WIP] release schedule upcoming length adjustment Jan 16, 2025

actual-github-bot bot added the 🚧 WIP label Jan 16, 2025

matt-fidd and others added 3 commits January 16, 2025 21:40

release schedule upcoming length adjustment

4404794

note

bfb5146

Update VRT

62db966

matt-fidd force-pushed the upcoming/release branch from c3bf165 to 62db966 Compare January 16, 2025 21:40

matt-fidd changed the title ~~[WIP] release schedule upcoming length adjustment~~ release schedule upcoming length adjustment Jan 16, 2025

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Jan 16, 2025

youngcw approved these changes Jan 16, 2025

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Jan 16, 2025

matt-fidd added this to the v25.2.0 milestone Jan 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

release schedule upcoming length adjustment #4173

release schedule upcoming length adjustment #4173

matt-fidd commented Jan 16, 2025

matt-fidd commented Jan 16, 2025

netlify bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

coderabbitai bot commented Jan 16, 2025

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

release schedule upcoming length adjustment #4173

Are you sure you want to change the base?

release schedule upcoming length adjustment #4173

Conversation

matt-fidd commented Jan 16, 2025

matt-fidd commented Jan 16, 2025

netlify bot commented Jan 16, 2025 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Jan 16, 2025 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Jan 16, 2025 • edited Loading

Bundle Stats — loot-core

coderabbitai bot commented Jan 16, 2025

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)