Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Redux Toolkit Migration] budgetsSlice #4114

Open
wants to merge 7 commits into
base: redux-toolkit-app-slice
Choose a base branch
from

Conversation

joel-jeremy
Copy link
Contributor

  • actions/account.ts / reducers/account.ts -> accounts/accountsSlice.ts [Redux Toolkit Migration] accountsSlice #4012
  • actions/queries.ts / reducers/queries.ts -> queries/queriesSlice.ts [Redux Toolkit Migration] queriesSlice #4016
  • actions/app.ts / reducers/app.ts -> app/appSlice.ts [Redux Toolkit Migration] appSlice #4018
  • actions/budgets.ts / reducers/budgets.ts -> budgets/budgetsSlice.ts
  • actions/modals.ts / reducers/modals.ts -> modals/modalsSlice.ts
  • actions/notifications.ts / reducers/notifications.ts -> notifications/notificationsSlice.ts
  • actions/prefs.ts / reducers/prefs.ts -> prefs/prefsSlice.ts
  • actions/user.ts / reducers/user.ts -> users/usersSlice.ts

@actual-github-bot actual-github-bot bot changed the title [Redux Toolkit Migration] budgetsSlice [WIP] [Redux Toolkit Migration] budgetsSlice Jan 8, 2025
Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 9d1bf98
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/677e296e8baa9f0008a8c2dd
😎 Deploy Preview https://deploy-preview-4114.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joel-jeremy joel-jeremy changed the base branch from master to redux-toolkit-app-slice January 8, 2025 07:30
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-app-slice branch from bea10bc to 45d239d Compare January 8, 2025 07:38
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-budgets-slice branch from 9d1bf98 to 85aa0b4 Compare January 8, 2025 07:38
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
13 6.45 MB → 6.45 MB (+1.58 kB) +0.02%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/client/budgets/budgetsSlice.ts 🆕 +11.18 kB 0 B → 11.18 kB
src/components/modals/LoadBackupModal.tsx 📈 +158 B (+3.08%) 5.01 kB → 5.17 kB
src/components/modals/manager/DuplicateFileModal.tsx 📈 +182 B (+2.53%) 7.03 kB → 7.21 kB
src/components/modals/manager/DeleteFileModal.tsx 📈 +135 B (+2.47%) 5.33 kB → 5.46 kB
home/runner/work/actual/actual/packages/loot-core/src/client/store/index.ts 📈 +28 B (+1.86%) 1.47 kB → 1.5 kB
src/index.tsx 📈 +16 B (+1.49%) 1.05 kB → 1.06 kB
src/components/modals/manager/ImportYNAB5Modal.tsx 📈 +48 B (+1.18%) 3.97 kB → 4.02 kB
src/components/modals/manager/ImportYNAB4Modal.tsx 📈 +48 B (+1.18%) 3.97 kB → 4.02 kB
src/components/modals/manager/ImportActualModal.tsx 📈 +48 B (+1.07%) 4.38 kB → 4.42 kB
home/runner/work/actual/actual/packages/loot-core/src/client/shared-listeners.ts 📈 +75 B (+0.87%) 8.42 kB → 8.5 kB
src/components/modals/TransferOwnership.tsx 📈 +50 B (+0.77%) 6.33 kB → 6.38 kB
home/runner/work/actual/actual/packages/loot-core/src/client/reducers/modals.ts 📈 +9 B (+0.68%) 1.28 kB → 1.29 kB
src/components/manager/BudgetList.tsx 📈 +118 B (+0.63%) 18.16 kB → 18.27 kB
src/components/App.tsx 📈 +22 B (+0.37%) 5.81 kB → 5.83 kB
src/components/manager/WelcomeScreen.tsx 📈 +2 B (+0.05%) 4.06 kB → 4.06 kB
home/runner/work/actual/actual/packages/loot-core/src/client/constants.ts 📉 -119 B (-16.23%) 733 B → 614 B
home/runner/work/actual/actual/packages/loot-core/src/client/reducers/index.ts 📉 -21 B (-16.80%) 125 B → 104 B
home/runner/work/actual/actual/packages/loot-core/src/client/actions/budgets.ts 🔥 -6.42 kB (-100%) 6.42 kB → 0 B
home/runner/work/actual/actual/packages/loot-core/src/client/reducers/budgets.ts 🔥 -3.43 kB (-100%) 3.43 kB → 0 B
home/runner/work/actual/actual/packages/loot-core/src/client/actions/backups.ts 🔥 -534 B (-100%) 534 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 4.21 MB → 4.21 MB (+1.58 kB) +0.04%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/en-GB.js 97.12 kB 0%
static/js/en.js 97.13 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/AppliedFilters.js 10.21 kB 0%
static/js/useAccountPreviewTransactions.js 1.63 kB 0%
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/uk.js 119.92 kB 0%
static/js/narrow.js 84.7 kB 0%
static/js/wide.js 101.22 kB 0%
static/js/ReportRouter.js 1.59 MB 0%

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.33 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.33 MB 0%

@joel-jeremy joel-jeremy force-pushed the redux-toolkit-app-slice branch from 45d239d to d070f5c Compare January 8, 2025 07:57
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-budgets-slice branch from 85aa0b4 to d548b76 Compare January 8, 2025 07:57
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-app-slice branch from d070f5c to de19241 Compare January 8, 2025 08:15
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-budgets-slice branch from d548b76 to c8c44df Compare January 8, 2025 08:15
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-app-slice branch from de19241 to c674df1 Compare January 8, 2025 18:46
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-budgets-slice branch from c8c44df to a8fd07d Compare January 8, 2025 18:46
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-app-slice branch from c674df1 to fb42bd2 Compare January 8, 2025 21:44
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-budgets-slice branch from a8fd07d to 147278b Compare January 8, 2025 21:45
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-app-slice branch from fb42bd2 to ca87e7b Compare January 8, 2025 21:46
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-budgets-slice branch 3 times, most recently from fb5f58e to 794864d Compare January 8, 2025 21:57
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-app-slice branch 2 times, most recently from 1ed0633 to 421bb04 Compare January 9, 2025 09:03
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-budgets-slice branch from 794864d to b9fe8ac Compare January 9, 2025 09:04
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-app-slice branch from 421bb04 to 37f7045 Compare January 10, 2025 17:21
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-budgets-slice branch from fee5ecb to 72be8e4 Compare January 10, 2025 17:22
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-app-slice branch from 37f7045 to aad3e10 Compare January 10, 2025 21:47
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-budgets-slice branch from 1bf6893 to 823f6d4 Compare January 10, 2025 21:48
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-app-slice branch from aad3e10 to 971119c Compare January 13, 2025 23:01
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-budgets-slice branch from 823f6d4 to c1e0f46 Compare January 13, 2025 23:01
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-app-slice branch from 971119c to 78e7af6 Compare January 13, 2025 23:23
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-budgets-slice branch from f7b3341 to e822d99 Compare January 13, 2025 23:24
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-app-slice branch from 78e7af6 to 9a4e154 Compare January 14, 2025 08:17
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-budgets-slice branch from e822d99 to c10b812 Compare January 14, 2025 08:17
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-app-slice branch from 9a4e154 to 0f10444 Compare January 14, 2025 16:44
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-budgets-slice branch 2 times, most recently from 5f5f286 to 4cae33a Compare January 14, 2025 17:41
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-app-slice branch 2 times, most recently from 9baef3e to 156e0ba Compare January 17, 2025 17:40
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-budgets-slice branch from 4cae33a to a9c708f Compare January 17, 2025 17:40
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-app-slice branch from 156e0ba to bc0672e Compare January 17, 2025 18:46
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-budgets-slice branch from a9c708f to 7f38a24 Compare January 17, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant