Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Redux Toolkit Migration] usersSlice [Final PR] #4128

Open
wants to merge 6 commits into
base: redux-toolkit-prefs-slice
Choose a base branch
from

Conversation

joel-jeremy
Copy link
Contributor

@joel-jeremy joel-jeremy commented Jan 10, 2025

@actual-github-bot actual-github-bot bot changed the title [Redux Toolkit Migration] usersSlice [WIP] [Redux Toolkit Migration] usersSlice Jan 10, 2025
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit c15ad84
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6781975f37bfa90008630b4f
😎 Deploy Preview https://deploy-preview-4128.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joel-jeremy joel-jeremy changed the base branch from master to redux-toolkit-prefs-slice January 10, 2025 21:55
Copy link
Contributor

github-actions bot commented Jan 10, 2025

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
22 5.98 MB → 6.07 MB (+97.43 kB) +1.59%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/client/users/usersSlice.ts 🆕 +1.03 kB 0 B → 1.03 kB
locale/en-GB.json 📈 +96.9 kB (+522226.32%) 19 B → 96.92 kB
home/runner/work/actual/actual/packages/loot-core/src/client/app/appSlice.ts 📈 +1.67 kB (+226.92%) 754 B → 2.41 kB
home/runner/work/actual/actual/packages/loot-core/src/client/store/index.ts 📈 +50 B (+4.37%) 1.12 kB → 1.17 kB
home/runner/work/actual/actual/packages/loot-core/src/client/modals/modalsSlice.ts 📈 +41 B (+1.97%) 2.03 kB → 2.07 kB
home/runner/work/actual/actual/packages/loot-core/src/client/shared-listeners.ts 📈 +144 B (+1.57%) 8.98 kB → 9.12 kB
src/components/App.tsx 📈 +31 B (+0.51%) 5.89 kB → 5.92 kB
home/runner/work/actual/actual/packages/loot-core/src/client/budgets/budgetsSlice.ts 📈 +49 B (+0.42%) 11.36 kB → 11.4 kB
src/components/admin/UserDirectory/UserDirectory.tsx 📈 +35 B (+0.36%) 9.4 kB → 9.43 kB
src/components/mobile/accounts/AccountTransactions.tsx 📈 +18 B (+0.22%) 8 kB → 8.02 kB
src/components/accounts/Account.tsx 📈 +25 B (+0.05%) 46.71 kB → 46.74 kB
src/components/mobile/accounts/Accounts.tsx 📈 +2 B (+0.02%) 8.4 kB → 8.4 kB
home/runner/work/actual/actual/packages/loot-core/src/client/actions/index.ts +0 B (0%) 0 B → 0 B
home/runner/work/actual/actual/packages/loot-core/src/client/actions/sync.ts 🔥 -1.65 kB (-100%) 1.65 kB → 0 B
home/runner/work/actual/actual/packages/loot-core/src/client/actions/user.ts 🔥 -548 B (-100%) 548 B → 0 B
home/runner/work/actual/actual/packages/loot-core/src/client/reducers/user.ts 🔥 -231 B (-100%) 231 B → 0 B
home/runner/work/actual/actual/packages/loot-core/src/client/constants.ts 🔥 -104 B (-100%) 104 B → 0 B
home/runner/work/actual/actual/packages/loot-core/src/client/reducers/index.ts 🔥 -38 B (-100%) 38 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/en-GB.js 19 B → 96.92 kB (+96.9 kB) +522226.32%
static/js/index.js 3.79 MB → 3.79 MB (+504 B) +0.01%
static/js/wide.js 107.1 kB → 107.12 kB (+25 B) +0.02%
static/js/narrow.js 87.28 kB → 87.3 kB (+20 B) +0.02%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/nb-NO.js 19 B 0%
static/js/cy.js 17 B 0%
static/js/pl.js 17 B 0%
static/js/de.js 4.59 kB 0%
static/js/fr.js 13.11 kB 0%
static/js/ta.js 17 B 0%
static/js/es.js 3.45 kB 0%
static/js/pt-BR.js 775 B 0%
static/js/zh-Hant.js 10.13 kB 0%
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/en.js 96.91 kB 0%
static/js/uk.js 120.47 kB 0%
static/js/useAccountPreviewTransactions.js 1.63 kB 0%
static/js/AppliedFilters.js 10.27 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/ReportRouter.js 1.59 MB 0%

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.33 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.33 MB 0%

@joel-jeremy joel-jeremy changed the title [WIP] [Redux Toolkit Migration] usersSlice [WIP] [Redux Toolkit Migration] usersSlice [Final PR] Jan 10, 2025
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-users-slice branch from c15ad84 to 96ff1d9 Compare January 13, 2025 23:03
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-prefs-slice branch from 5cbdb7d to 582138a Compare January 13, 2025 23:04
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-users-slice branch from 96ff1d9 to 0ee4194 Compare January 13, 2025 23:04
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-prefs-slice branch from 582138a to f0e15a2 Compare January 13, 2025 23:12
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-users-slice branch from 0ee4194 to 2fa3739 Compare January 13, 2025 23:12
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-prefs-slice branch from f0e15a2 to 1e4d9a1 Compare January 13, 2025 23:26
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-users-slice branch from 2fa3739 to 371697c Compare January 13, 2025 23:26
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-prefs-slice branch from 1e4d9a1 to af70553 Compare January 14, 2025 08:19
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-users-slice branch from 371697c to 16aaaaf Compare January 14, 2025 08:19
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-prefs-slice branch from af70553 to 389b7ae Compare January 14, 2025 16:45
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-users-slice branch from 16aaaaf to 9214d3c Compare January 14, 2025 16:45
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-prefs-slice branch from 389b7ae to a42f2b3 Compare January 14, 2025 17:16
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-users-slice branch from 9214d3c to 89e607d Compare January 14, 2025 17:16
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-prefs-slice branch from a42f2b3 to 43b6e4e Compare January 14, 2025 17:57
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-users-slice branch from 5a17f91 to 1c523c2 Compare January 14, 2025 17:58
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-prefs-slice branch from 43b6e4e to 29faba1 Compare January 14, 2025 18:10
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-users-slice branch from aec5914 to 27fbc36 Compare January 14, 2025 18:11
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-prefs-slice branch from 29faba1 to 63a022d Compare January 17, 2025 17:46
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-users-slice branch from fa3c692 to 5330b1e Compare January 17, 2025 17:46
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-prefs-slice branch from 63a022d to 65641d0 Compare January 17, 2025 19:23
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-users-slice branch from 5330b1e to 4d6edf4 Compare January 17, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant