Skip to content

fix: correct new_artifact methods signature #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 21, 2025
+6 −4
Merged

fix: correct new_artifact methods signature #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd300ed
fix: correct `new_artifact` methods description according to Artifact…
Lancetnik Oct 13, 2025
37f0f8e
test: empty description now None
Lancetnik Oct 13, 2025
88d438a
Merge branch 'main' into patch-2
holtskinner Oct 15, 2025
78422eb
Merge branch 'main' into patch-2
holtskinner Oct 21, 2025
d3bb856
Merge branch 'main' into patch-2
holtskinner Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/a2a/utils/artifact.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@


def new_artifact(
parts: list[Part], name: str, description: str = ''
parts: list[Part],
name: str,
description: str | None = None,
) -> Artifact:
"""Creates a new Artifact object.

Expand All @@ -32,7 +34,7 @@ def new_artifact(
def new_text_artifact(
name: str,
text: str,
description: str = '',
description: str | None = None,
) -> Artifact:
"""Creates a new Artifact object containing only a single TextPart.

Expand All @@ -54,7 +56,7 @@ def new_text_artifact(
def new_data_artifact(
name: str,
data: dict[str, Any],
description: str = '',
description: str | None = None,
) -> Artifact:
"""Creates a new Artifact object containing only a single DataPart.

Expand Down
2 changes: 1 addition & 1 deletion tests/utils/test_artifact.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def test_new_artifact_empty_description_if_not_provided(self):
parts = [Part(root=TextPart(text='Another sample'))]
name = 'Artifact_No_Desc'
artifact = new_artifact(parts=parts, name=name)
self.assertEqual(artifact.description, '')
self.assertEqual(artifact.description, None)

def test_new_text_artifact_creates_single_text_part(self):
text = 'This is a text artifact.'
Expand Down
Loading