-
Notifications
You must be signed in to change notification settings - Fork 261
fix: correct new_artifact
methods signature
#503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… field type Artifact class has nullable description with default None `Artifact(description: str | None = None)` But, utilities functions creates and artifact with empty description by default `description=''`
Summary of ChangesHello @Lancetnik, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a type inconsistency where artifact creation utility functions were defaulting the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
new_artifact
methods description according to Artifact…new_artifact
methods signature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the description
parameter in artifact creation utility functions to default to None
instead of an empty string, which aligns with the Artifact
type definition. This is a good fix for consistency. I've left one comment regarding a necessary update to a unit test that seems to be broken by this change. Please address it to ensure the test suite passes.
🤖 I have created a release *beep* *boop* --- ## [0.3.10](v0.3.9...v0.3.10) (2025-10-21) ### Features * add `get_artifact_text()` helper method ([9155888](9155888)) * Add a `ClientFactory.connect()` method for easy client creation ([d585635](d585635)) ### Bug Fixes * change `MAX_CONTENT_LENGTH` (for file attachment) in json-rpc to be larger size (10mb) ([#518](#518)) ([5b81385](5b81385)) * correct `new_artifact` methods signature ([#503](#503)) ([ee026aa](ee026aa)) ### Code Refactoring * **utils:** move part helpers to their own file ([9155888](9155888)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Artifact class has nullable description with default None
Artifact(description: str | None = None)
But, utilities functions creates and artifact with empty description by default
description=''
Release-As: 0.3.10