Skip to content

Conversation

Lancetnik
Copy link
Contributor

@Lancetnik Lancetnik commented Oct 13, 2025

Artifact class has nullable description with default None Artifact(description: str | None = None)

But, utilities functions creates and artifact with empty description by default description=''

Release-As: 0.3.10

… field type

Artifact class has nullable description with default None `Artifact(description: str | None = None)` 

But, utilities functions creates and artifact with empty description by default `description=''`
@Lancetnik Lancetnik requested a review from a team as a code owner October 13, 2025 17:04
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Lancetnik, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a type inconsistency where artifact creation utility functions were defaulting the description parameter to an empty string, while the Artifact class itself allowed None. The changes ensure that these utility functions now correctly reflect the Artifact class's nullable description field by setting the default value to None, improving type consistency and clarity across the codebase.

Highlights

  • Type Signature Alignment: The description parameter in new_artifact, new_text_artifact, and new_data_artifact utility functions has been updated to str | None = None, aligning with the Artifact class's nullable description field.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Lancetnik Lancetnik changed the title fix: correct new_artifact methods description according to Artifact… fix: correct new_artifact methods signature Oct 13, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the description parameter in artifact creation utility functions to default to None instead of an empty string, which aligns with the Artifact type definition. This is a good fix for consistency. I've left one comment regarding a necessary update to a unit test that seems to be broken by this change. Please address it to ensure the test suite passes.

@holtskinner holtskinner enabled auto-merge (squash) October 21, 2025 20:35
@holtskinner holtskinner disabled auto-merge October 21, 2025 20:35
@holtskinner holtskinner enabled auto-merge (squash) October 21, 2025 20:36
@holtskinner holtskinner merged commit ee026aa into a2aproject:main Oct 21, 2025
7 checks passed
holtskinner pushed a commit that referenced this pull request Oct 21, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.3.10](v0.3.9...v0.3.10)
(2025-10-21)


### Features

* add `get_artifact_text()` helper method
([9155888](9155888))
* Add a `ClientFactory.connect()` method for easy client creation
([d585635](d585635))


### Bug Fixes

* change `MAX_CONTENT_LENGTH` (for file attachment) in json-rpc to be
larger size (10mb)
([#518](#518))
([5b81385](5b81385))
* correct `new_artifact` methods signature
([#503](#503))
([ee026aa](ee026aa))


### Code Refactoring

* **utils:** move part helpers to their own file
([9155888](9155888))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants