Skip to content

Remove sponsorship link from About screen - #909

Merged
a-ghorbani merged 2 commits into
mainfrom
feature/TASK-20260910-1539
Sep 10, 2026
Merged

Remove sponsorship link from About screen#909
a-ghorbani merged 2 commits into
mainfrom
feature/TASK-20260910-1539

Conversation

@pocketpal-dev-team

@pocketpal-dev-team pocketpal-dev-team Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the "Become a Sponsor" button (an external Buy Me a Coffee donation link) from the About screen on every platform.

Why: Google Play's Payments policy does not allow an in-app link to an external donation page. The button was already hidden on iOS behind a Platform.OS !== 'ios' gate; this removes it everywhere and drops the gate.

Changes

  • src/screens/AboutScreen/AboutScreen.tsx: remove the sponsor button, the "or" separator before it, and the Platform.OS gate. Drop the now-unused Platform and HeartIcon imports.
  • src/screens/AboutScreen/styles.ts: remove the unused supportButton / supportButtonText styles. orText stays because the "or by" line still uses it.
  • src/locales/en.json: remove the now-unused about.sponsorButton and about.orText keys.
  • src/screens/AboutScreen/__tests__/AboutScreen.test.tsx: replace the sponsor-URL test and the iOS-hidden test with a check, run on both Android and iOS, that no sponsor button or stray "or" separator renders, while "Star on GitHub", "or by", and the share-thoughts button are still there.

The support section now reads: "…please consider supporting the project by:" → Star on GitHub → "or by" → Sharing your thoughts. No copy was added.

Only en.json is edited (per CONTRIBUTING.md, the other locales are managed on Weblate); Weblate's cleanup add-on drops the stale keys from them after merge.

Out of scope: the README's GitHub Sponsors badge and link are not in the app, so they are untouched. The HeartIcon export stays in the shared icon barrel.

Verification

  • yarn lint: 0 errors (the 49 existing warnings are all outside the files changed here)
  • yarn typecheck: pass
  • yarn l10n:validate: pass
  • yarn test --coverage: 4379 passed, 2 skipped, 0 failed. Global line coverage 76.9%; AboutScreen.tsx 89.6%.
  • Checked that the new test is not vacuous: run against the previous AboutScreen.tsx, styles.ts, and en.json, the Android case fails and the iOS case passes (iOS was already gated).
  • No native or package.json changes.

Before/after Android screenshots of the About screen are in the comments below.

Generated by PocketPal Dev Team · Claude Code

Google Play's Payments policy does not allow an in-app donation link, and
it had already been removed on iOS. The GitHub button and the feedback
entry remain as the ways to support the project.
Only the source locale is edited; the other locales are synced by Weblate,
which removes keys that no longer exist in en.
@pocketpal-dev-team pocketpal-dev-team Bot added the enhancement New feature or request label Sep 10, 2026
@pocketpal-dev-team

Copy link
Copy Markdown
Contributor Author

Visual evidence — About screen, Android

The "Support the Project" section loses the sponsor button and the "or" separator above it. The GitHub and feedback options are unchanged.

Before (main) After (this PR)
About screen before: Star on GitHub, or, Become a Sponsor, or by, Sharing your thoughts About screen after: Star on GitHub, or by, Sharing your thoughts

OnePlus 6, Android 11. iOS is not shown, because the button was already hidden there and the iOS screen does not change.

How these builds were made
  • Both screenshots come from the same CI e2e APK. It was built from a commit with no native or package.json differences from this PR's base.
  • A JS bundle compiled locally was put into that APK: before from ced4fadf (base), after from 0f16642e (head). Both APKs were then re-signed with a throwaway key.
  • The bundle inside the installed after APK matches the bundle built from head, byte for byte.
  • In that bundle, "Become a Sponsor" and "buymeacoffee" appear 0 times, while the control strings (e.g. "Support the Project") are present.

Generated by PocketPal Dev Team · Claude Code

@a-ghorbani
a-ghorbani marked this pull request as ready for review September 10, 2026 14:42

@a-ghorbani a-ghorbani left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@a-ghorbani
a-ghorbani merged commit e02f298 into main Sep 10, 2026
4 checks passed
@a-ghorbani
a-ghorbani deleted the feature/TASK-20260910-1539 branch September 10, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant