Remove sponsorship link from About screen (#909)

* feat(about): remove the sponsorship button from the About screen

Google Play's Payments policy does not allow an in-app donation link, and
it had already been removed on iOS. The GitHub button and the feedback
entry remain as the ways to support the project.

* chore(l10n): drop the unused sponsor and separator strings from en

Only the source locale is edited; the other locales are synced by Weblate,
which removes keys that no longer exist in en.

---------

Co-authored-by: a-ghorbani <ghorbani59@gmail.com>

Author: pocketpal-dev-team[bot]

src/locales/en.json

@@ -507,9 +507,7 @@
     "supportProject": "Support the Project",
     "supportProjectDescription": "If you enjoy using PocketPal AI, please consider supporting the project by:",
     "githubButton": "Star on GitHub",
-    "orText": "or",
     "orBy": "or by",
-    "sponsorButton": "Become a Sponsor",
     "versionCopiedTitle": "Version copied",
     "versionCopiedDescription": "Version information has been copied to clipboard",
     "tour": "Tour",

src/screens/AboutScreen/AboutScreen.tsx

@@ -1,12 +1,5 @@
 import React, {useState, useContext} from 'react';
-import {
-  View,
-  ScrollView,
-  TouchableOpacity,
-  Alert,
-  Linking,
-  Platform,
-} from 'react-native';
+import {View, ScrollView, TouchableOpacity, Alert, Linking} from 'react-native';
 
 import DeviceInfo from 'react-native-device-info';
 import Clipboard from '@react-native-clipboard/clipboard';
@@ -16,12 +9,7 @@ import {BuildInfo} from 'llama.rn';
 
 import {submitFeedback} from '../../api/feedback';
 
-import {
-  CopyIcon,
-  GithubIcon,
-  ChevronRightIcon,
-  HeartIcon,
-} from '../../assets/icons';
+import {CopyIcon, GithubIcon, ChevronRightIcon} from '../../assets/icons';
 
 import {Sheet, TextInput} from '../../components';
 import {useTheme} from '../../hooks';
@@ -150,21 +138,6 @@ export const AboutScreen: React.FC = () => {
               icon={GithubButtonIcon}>
               {l10n.about.githubButton}
             </Button>
-            {Platform.OS !== 'ios' && (
-              <>
-                <Text style={styles.orText}>{l10n.about.orText}</Text>
-                <TouchableOpacity
-                  style={styles.supportButton}
-                  onPress={() =>
-                    Linking.openURL('https://www.buymeacoffee.com/aghorbani')
-                  }>
-                  <HeartIcon stroke={theme.colors.onPrimary} />
-                  <Text style={styles.supportButtonText}>
-                    {l10n.about.sponsorButton}
-                  </Text>
-                </TouchableOpacity>
-              </>
-            )}
             <Text style={styles.orText}>{l10n.about.orBy}</Text>
             <Button
               mode="outlined"

src/screens/AboutScreen/__tests__/AboutScreen.test.tsx

@@ -69,22 +69,26 @@ describe('AboutScreen', () => {
     );
   });
 
-  it('opens Buy Me a Coffee URL when sponsor button is pressed on non-iOS platforms', () => {
-    Platform.OS = 'android';
-    const {getByText} = render(<AboutScreen />);
+  describe.each(['android', 'ios'] as const)('on %s', os => {
+    const originalOS = Platform.OS;
 
-    fireEvent.press(getByText(l10n.en.about.sponsorButton));
+    beforeEach(() => {
+      Platform.OS = os;
+    });
 
-    expect(Linking.openURL).toHaveBeenCalledWith(
-      'https://www.buymeacoffee.com/aghorbani',
-    );
-  });
+    afterEach(() => {
+      Platform.OS = originalOS;
+    });
 
-  it('does not show sponsor button on iOS', () => {
-    Platform.OS = 'ios';
-    const {queryByText} = render(<AboutScreen />);
+    it('shows no sponsorship option in the support section', () => {
+      const {queryByText, getByText} = render(<AboutScreen />);
 
-    expect(queryByText(l10n.en.about.sponsorButton)).toBeNull();
+      expect(queryByText('Become a Sponsor')).toBeNull();
+      expect(queryByText('or')).toBeNull();
+      expect(getByText(l10n.en.about.githubButton)).toBeTruthy();
+      expect(getByText(l10n.en.about.orBy)).toBeTruthy();
+      expect(getByText(l10n.en.feedback.shareThoughtsButton)).toBeTruthy();
+    });
   });
 
   it('opens feedback form when share thoughts button is pressed', async () => {

src/screens/AboutScreen/styles.ts

@@ -93,28 +93,6 @@ export const createStyles = (theme: Theme, insets: EdgeInsets) =>
       marginVertical: theme.spacing.default,
       opacity: 0.7,
     },
-    supportButton: {
-      flexDirection: 'row',
-      alignItems: 'center',
-      justifyContent: 'center',
-      backgroundColor: theme.colors.primary,
-      padding: theme.spacing.default,
-      borderRadius: theme.borders.default,
-      gap: theme.spacing.default / 2,
-      shadowColor: theme.colors.primary,
-      shadowOffset: {
-        width: 0,
-        height: 2,
-      },
-      shadowOpacity: 0.2,
-      shadowRadius: 4,
-      elevation: 2,
-    },
-    supportButtonText: {
-      ...theme.fonts.titleMedium,
-      color: theme.colors.onPrimary,
-      letterSpacing: 0.5,
-    },
     feedbackButtonContent: {
       flexDirection: 'row-reverse',
     },