Temporarily revert #6101 and #6077 - #6182
Merged
Merged
Conversation
Member
|
@Ravenslofty gatemate tests are failing with |
Ravenslofty
force-pushed
the
lofty/revert-read_xaiger2
branch
from
September 7, 2026 16:51
9feb133 to
51583d8
Compare
KrystalDelusion
approved these changes
Sep 7, 2026
KrystalDelusion
left a comment
KrystalDelusion
left a comment
Member
There was a problem hiding this comment.
No complaints from me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
The current
write_xaiger2/read_xaigerflow inabc_newcauses issues such as #6179. That can be fixed by #6174, but I'd like that PR to have some time to soak and find bugs in main before reaching a release. With the September release imminent, I think it's best to temporarily revert #6101 and #6077 before that release, then they can be "unreverted" and #6174 merged.Explain how this is achieved.
Temporarily yeet.