Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add russian translation #37

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add russian translation #37

wants to merge 2 commits into from

Conversation

Katrovsky
Copy link

No description provided.

@Katrovsky Katrovsky changed the title Add russian locale Add russian translation Nov 12, 2024
@YorVeX
Copy link
Owner

YorVeX commented Nov 14, 2024

Thanks a lot for submitting a new translation!

Please note that double quotes (") are used to indicate the start and end of a text string, meaning if you use it within the text, the text will prematurely end there.

So for example this will never show the "BeamSender" part, it will just stop after используется:
IdentifierText="Идентификатор отправителя. Это используется для идентификации отправителя на приемнике. По умолчанию, если пусто, используется "BeamSender"."

To use double quotes within the text, they need to be escaped like this: \"

Meaning the above example needs to look like this:
IdentifierText="Идентификатор отправителя. Это используется для идентификации отправителя на приемнике. По умолчанию, если пусто, используется \"BeamSender\"."

Would you please be so kind to fix this for the PR?

What could help finding all the cases where it occurs is the syntax highlighting if you check this PR, the affected items will have a different text color:
image

image

@YorVeX YorVeX self-requested a review November 14, 2024 06:11
@Katrovsky
Copy link
Author

Give me some time, please, I'll fix it. :)

Carefully rechecked the entire text, corrected all errors. Thanks for waiting. :)
@Katrovsky
Copy link
Author

I probably should have written about it explicitly, so I'm sorry: everything is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants