Skip to content

Hide msvc warning suppression pragma behind gate #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YaaZ merged 1 commit into from
Jan 17, 2026
+6 −2
Merged

Hide msvc warning suppression pragma behind gate #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion VmaHppGenerator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1975,7 +1975,9 @@ void generateHandles(const Source& source, Symbols& symbols) {
#endif

#ifndef VULKAN_HPP_DISABLE_ENHANCED_MODE
#pragma warning(disable : 4834) // MSVC thinks we are discarding chained return values, like foo(), detail::wrap<...>(...)
#if defined( _MSC_VER )
# pragma warning(disable : 4834) // MSVC thinks we are discarding chained return values, like foo(), detail::wrap<...>(...)
#endif
namespace VMA_HPP_NAMESPACE {
namespace VMA_HPP_RAII_NAMESPACE {
namespace detail {
Expand Down
4 changes: 3 additions & 1 deletion include/vk_mem_alloc_raii.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
#endif

#ifndef VULKAN_HPP_DISABLE_ENHANCED_MODE
#pragma warning(disable : 4834) // MSVC thinks we are discarding chained return values, like foo(), detail::wrap<...>(...)
#if defined( _MSC_VER )
# pragma warning(disable : 4834) // MSVC thinks we are discarding chained return values, like foo(), detail::wrap<...>(...)
#endif
namespace VMA_HPP_NAMESPACE {
namespace VMA_HPP_RAII_NAMESPACE {
namespace detail {
Expand Down