Skip to content

Conversation

@M2-TE
Copy link

@M2-TE M2-TE commented Jan 6, 2026

Non-MSVC compilers will complain otherwise; as an example from Clang 21:

In file included from include/vk_mem_alloc.cppm:6:
include/vk_mem_alloc_raii.hpp:11:9: warning: unknown pragma ignored [-Wunknown-pragmas]
   11 | #pragma warning(disable : 4834) // MSVC thinks we are discarding chained return values, like foo(), detail::wrap<...>(...)
      |         ^

This pragma is now hidden behind #if defined( _MSC_VER ), similar to how Vulkan-Hpp does it.

Copy link
Owner

@YaaZ YaaZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@YaaZ YaaZ merged commit d959558 into YaaZ:master Jan 17, 2026
52 checks passed
@M2-TE M2-TE deleted the pragma-msvc branch January 17, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants