Upstream sync#435
Open
VIXIVIXIV wants to merge 30 commits into
Open
Conversation
Signed-off-by: Timofey Titovets <nefelim4ag@gmail.com>
Signed-off-by: Dmitry Butyugin <dmbutyugin@google.com>
Signed-off-by: Dmitry Butyugin <dmbutyugin@google.com>
Also increased the maximum number of input shaper pulses Signed-off-by: Dmitry Butyugin <dmbutyugin@google.com>
Signed-off-by: Dmitry Butyugin <dmbutyugin@google.com>
Signed-off-by: Dmitry Butyugin <dmbutyugin@google.com>
Signed-off-by: Dmitry Butyugin <dmbutyugin@google.com>
Due to recent changes, a shutdown log line may not have a description. Update the logextract.py script accordingly. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Now that "tap" support does not require the scipy package to be installed it is reasonable to activate "tap" for all configurations. This can make the initial calibration easier. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Rework the tap_threshold to use units of hz/mm (instead of hz). This will make it easier to implement tap calibration based on results of PROBE_EDDY_CURRENT_CALIBRATE and previous tap attempts. It can also make the tap_threshold more stable with different probe speeds and sensor rates. As a result of this change, existing user configurations will need to be updated. It is hoped that existing configurations will have a value that is sufficiently low that they will reliably get an error until they can recalibrate. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Add a command to help configure the tap_threshold parameter. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Increase the sample rate so that more samples are available during "tap" analysis. Further increases to the sample rate will likely provide diminishing returns. The ldc1612 sensor seems to exhibit internal quantization (that is, repeat identical values are frequently observed). So, it seems increasing above 250sps can provide some additional information, but going much higher is unlikely to provide significant benefit. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Signed-off-by: Dmitry Butyugin <dmbutyugin@google.com>
Commit db10e92 ("shaper_defs: Support parameterized shaper initialization") refactored InputShaperParams.update() so that the new shaper frequency is read from the gcode command into a local variable 'shaper_freq' for validation via get_shaper(). However, unlike 'damping_ratio' and 'shaper_type', the validated 'shaper_freq' is never written back to 'self.shaper_freq'. As a result, runtime SET_INPUT_SHAPER commands that include SHAPER_FREQ_X / SHAPER_FREQ_Y do not change the actual shaping frequency -- it silently keeps using the value loaded from [input_shaper] at startup. This breaks slicer-driven input shaper tuning towers and toolchanger setups that switch shaper frequencies per tool. Signed-off-by: Christian Rödel <christianad5@yahoo.de>
…class Move the handling of the PROBE_EDDY_CURRENT_CALIBRATE command to a new EddyCalibrationTool class. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Provide more information on the different probe types available when using an eddy current probe. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Signed-off-by: Dmitry Butyugin <dmbutyugin@google.com>
Signed-off-by: Dmitry Butyugin <dmbutyugin@google.com>
Signed-off-by: Dmitry Butyugin <dmbutyugin@google.com>
Add a new option so that setting of sensor_div is more robust. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
…n_solve() Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Python is faster with list comprehensions than generators (prefer `sum([x for x in c])` over `sum(x for x in c)` ). Python2 is faster if lists are built with list comprehensions instead of appending. Optimize the common `mat_mat_mul(mat_transp(a), a)` as only roughly half the results are unique. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
It's simpler and more accurate to use linear least squares. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
It's simpler and more accurate to use linear least squares. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Signed-off-by: Timofey Titovets <nefelim4ag@gmail.com>
Signed-off-by: Dmitry Butyugin <dmbutyugin@google.com>
Signed-off-by: Dmitry Butyugin <dmbutyugin@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.