Add SMU node-type #845
Open
Add SMU node-type #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Pitz <[email protected]> Signed-off-by: Alexandra <[email protected]>
stv0g
requested changes
Jan 23, 2025
There was a problem hiding this comment.
I started to review this PR, but before I continue, I would like to ask you to:
- Remove all dead code
- Fix the commenting style, to be in line with the remaining code of VILLAS
- Run clang-format
- Fix the CI pipeline
- Add missing documentation:
- To the OpenAPI spec: https://github.com/VILLASframework/node/tree/master/doc/openapi/components/schemas/config/nodes
- To the documentation repo
|
Hi @al3xa23, I've met Cesar on our last SEGuRo project meeting and we talked about the SMU code. He mentioned that he still wants to get this merged into VILLASnode. @windrad6 Maybe, you know more about the next steps here? Let me know if there is something I can do to unblock this. |
Signed-off-by: Alexandra <[email protected]>
Signed-off-by: Alexandra <[email protected]>
Signed-off-by: Alexandra <[email protected]>
Signed-off-by: Alexandra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new smu branch because commit history was pretty messed up. Everything now is based on the status of the the old branch, but all smu changes included in one commit. Hope it is fine like that