-
Couldn't load subscription status.
- Fork 16
chore: remove catchall codeowner #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
babd5d7 to
306eea8
Compare
I agree. It does not work with me as the only reviewer and maintainer.
So, in my opinion the solution should not be to remove me as a codeowner, but instead find other people who are interested in this task. Do we have any volunteers? Unfortunately, there seems nobody else interested in providing some reviews. And by "reviewing" I dont mean to simply "approve" a PR from a colleague to do them a favour. It like with publications.. It is a bit sad :( I am against removing the requirement for a review as this will deteriorate the code quality over time. If you we dont find somebody else to work on this, I suggest we better fork personal work into personal repos or split the project again. |
|
I don't have a good solution to all of this. |
|
@n-eiling Would you volunteer as a second catch-all codeowner? |
|
@n-eiling ping |
|
Yes, but I don't think this will help much. I will not have a lot of time to do reviews in the future. We should find even more people. |
Signed-off-by: Niklas Eiling <[email protected]>
Signed-off-by: Niklas Eiling <[email protected]>
Signed-off-by: Niklas Eiling <[email protected]>
84816f7 to
0b0c1c5
Compare
@stv0g You as default code owner for everything just doesn't work anymore.
We cannot wait for 3 months for a review. I'd suggest you add yourself to parts that are very important to you.
Or do you have another idea for a solution?