Skip to content

Conversation

@n-eiling
Copy link
Member

@stv0g You as default code owner for everything just doesn't work anymore.
We cannot wait for 3 months for a review. I'd suggest you add yourself to parts that are very important to you.
Or do you have another idea for a solution?

@n-eiling n-eiling requested a review from stv0g as a code owner January 24, 2025 09:35
@n-eiling n-eiling closed this Jan 24, 2025
@n-eiling n-eiling deleted the modify-codeowners branch January 24, 2025 10:35
@n-eiling n-eiling restored the modify-codeowners branch January 24, 2025 10:35
@n-eiling n-eiling reopened this Jan 24, 2025
@n-eiling n-eiling enabled auto-merge (rebase) January 24, 2025 10:52
@stv0g
Copy link
Contributor

stv0g commented Jan 28, 2025

We cannot wait for 3 months for a review.

I agree. It does not work with me as the only reviewer and maintainer.

Or do you have another idea for a solution?

So, in my opinion the solution should not be to remove me as a codeowner, but instead find other people who are interested in this task.

Do we have any volunteers?

Unfortunately, there seems nobody else interested in providing some reviews. And by "reviewing" I dont mean to simply "approve" a PR from a colleague to do them a favour.
A review takes time and some effort to understand the changes. So a review without any comments, questions or remarks is not proper review.

It like with publications..

It is a bit sad :( I am against removing the requirement for a review as this will deteriorate the code quality over time. If you we dont find somebody else to work on this, I suggest we better fork personal work into personal repos or split the project again.

@stv0g
Copy link
Contributor

stv0g commented Jan 28, 2025

@n-eiling Are there more PR's to review? I provided quite a few reviews over the last weeks (see #853, #846, #845). But those reviews have remained all unanswered which is not improving my motivation to dedicate time to this :/

@n-eiling
Copy link
Member Author

n-eiling commented Jan 29, 2025

I don't have a good solution to all of this.
We will not find anyone willing to do code reviews on everything.
Code quality will deteriorate.
But if we don't change anything, the project will not get any more contributions.

@stv0g
Copy link
Contributor

stv0g commented Jan 29, 2025

@n-eiling Would you volunteer as a second catch-all codeowner?

@stv0g
Copy link
Contributor

stv0g commented Feb 10, 2025

@n-eiling ping

@n-eiling
Copy link
Member Author

Yes, but I don't think this will help much. I will not have a lot of time to do reviews in the future. We should find even more people.

@stv0g stv0g disabled auto-merge February 20, 2025 18:04
@stv0g stv0g force-pushed the modify-codeowners branch from 84816f7 to 0b0c1c5 Compare February 20, 2025 18:07
@stv0g stv0g merged commit 7b21c67 into master Feb 20, 2025
1 check passed
@stv0g stv0g deleted the modify-codeowners branch February 20, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants