fix: [Backport] MTTB-1273 Inconsistent scene name in scene event #3487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
|
|
||
| OnUnload?.Invoke(NetworkManager.LocalClientId, sceneName, sceneUnload); | ||
| InvokeSceneEvents(NetworkManager.LocalClientId, sceneEventData); |
There was a problem hiding this comment.
Does this need to go above the InvokeSceneEvents?
// The only scenes unloaded are scenes that were additively loaded
sceneEventData.LoadSceneMode = LoadSceneMode.Additive;
| }); | ||
|
|
||
| OnLoad?.Invoke(NetworkManager.LocalClientId, sceneName, loadSceneMode, sceneLoad); | ||
| InvokeSceneEvents(NetworkManager.LocalClientId, sceneEventData, sceneLoad); |
There was a problem hiding this comment.
Does this need to add the scene path or is that being automatically done?
| @@ -1736,7 +1760,9 @@ public NetcodeIntegrationTest(HostOrServer hostOrServer) | |||
| protected void AssertOnTimeout(string timeOutErrorMessage, TimeoutHelper assignedTimeoutHelper = null) | |||
| { | |||
| var timeoutHelper = assignedTimeoutHelper ?? s_GlobalTimeoutHelper; | |||
| Assert.False(timeoutHelper.TimedOut, timeOutErrorMessage); | |||
| var internalError = m_InternalErrorLog.Length > 0 ? $"{timeOutErrorMessage}\n{m_InternalErrorLog}" : timeOutErrorMessage; | |||
There was a problem hiding this comment.
Did this need to return early if length > 0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTTB-1278
fixes: #3418
Changelog
ScenePathfield on theSceneEventreturned by theOnSceneEventcallback.OnSceneEventcallback.Testing and Documentation
Backport
This is a backport of #3458