Skip to content

fix: MTTB-1273 Inconsistent SceneName in SceneEvent #3458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

EmandM
Copy link
Collaborator

@EmandM EmandM commented May 22, 2025

MTTB-1278
fixes: #3418

Changelog

  • Added: A ScenePath field on the SceneEvent returned by the OnSceneEvent callback.
  • Fixed: Various bugs around the OnSceneEvent callback.

Testing and Documentation

  • Includes unit tests.

Backport

Backported by #3487

@EmandM EmandM requested a review from a team as a code owner May 22, 2025 18:39
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up and fix.
👍

@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) May 29, 2025 15:24
@NoelStephensUnity NoelStephensUnity merged commit 448c38a into develop-2.0.0 May 29, 2025
42 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/mttb-1273/inconsistent-scene-name-in-scene-event branch May 29, 2025 18:12
EmandM added a commit that referenced this pull request May 30, 2025
<!-- Replace this block with what this PR does and why. Describe what
you'd like reviewers to know, how you applied the engineering
principles, and any interesting tradeoffs made. Delete bullet points
below that don't apply, and update the changelog section as appropriate.
-->

<!-- Add short version of the JIRA ticket to the PR title (e.g. "feat:
new shiny feature [MTT-123]") -->
[MTTB-1278](https://jira.unity3d.com/browse/MTTB-1273)

## Changelog

- Fixed: #3458 stopped sending scene events directly to the CMB service.
The CMB service uses those events for managing what objects exist. This
PR puts back sending those messages.

## Testing and Documentation

- Upgraded `InScenePlacedNetworkObjectTests` to work with the CMB
Service

<!-- Uncomment and mark items off with a * if this PR deprecates any
API:
### Deprecated API
- [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter
yyyy-mm-dd)` entry.
- [ ] An [api updater] was added.
- [ ] Deprecation of the API is explained in the CHANGELOG.
- [ ] The users can understand why this API was removed and what they
should use instead.
-->

## Backport

<!-- If this is a backport:
 - Add the following to the PR title: "\[Backport\] ..." .
 - Link to the original PR.
If this needs a backport - state this here
If a backport is not needed please provide the reason why.
If the "Backports" section is not present it will lead to a CI test
failure.
-->
No backport needed, only a 2.0.0 change.
@NoelStephensUnity NoelStephensUnity added the port:1.x-completed This issue was ported to 1.X branch label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port:1.x-completed This issue was ported to 1.X branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants