fix: MTTB-1273 Inconsistent SceneName in SceneEvent #3458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/com.unity.netcode.gameobjects into fix/mttb-1273/inconsistent-scene-name-in-scene-event
NoelStephensUnity
approved these changes
May 27, 2025
There was a problem hiding this comment.
Nice clean up and fix.
👍
…me-in-scene-event
…/com.unity.netcode.gameobjects into fix/mttb-1273/inconsistent-scene-name-in-scene-event
…me-in-scene-event
NoelStephensUnity
deleted the
fix/mttb-1273/inconsistent-scene-name-in-scene-event
branch
EmandM
added a commit
that referenced
this pull request
May 30, 2025
<!-- Replace this block with what this PR does and why. Describe what you'd like reviewers to know, how you applied the engineering principles, and any interesting tradeoffs made. Delete bullet points below that don't apply, and update the changelog section as appropriate. --> <!-- Add short version of the JIRA ticket to the PR title (e.g. "feat: new shiny feature [MTT-123]") --> [MTTB-1278](https://jira.unity3d.com/browse/MTTB-1273) ## Changelog - Fixed: #3458 stopped sending scene events directly to the CMB service. The CMB service uses those events for managing what objects exist. This PR puts back sending those messages. ## Testing and Documentation - Upgraded `InScenePlacedNetworkObjectTests` to work with the CMB Service <!-- Uncomment and mark items off with a * if this PR deprecates any API: ### Deprecated API - [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter yyyy-mm-dd)` entry. - [ ] An [api updater] was added. - [ ] Deprecation of the API is explained in the CHANGELOG. - [ ] The users can understand why this API was removed and what they should use instead. --> ## Backport <!-- If this is a backport: - Add the following to the PR title: "\[Backport\] ..." . - Link to the original PR. If this needs a backport - state this here If a backport is not needed please provide the reason why. If the "Backports" section is not present it will lead to a CI test failure. --> No backport needed, only a 2.0.0 change.
NoelStephensUnity
added
the
port:1.x-completed
EmandM
added a commit
that referenced
this pull request
Jun 12, 2025
<!-- Replace this block with what this PR does and why. Describe what you'd like reviewers to know, how you applied the engineering principles, and any interesting tradeoffs made. Delete bullet points below that don't apply, and update the changelog section as appropriate. --> <!-- Add short version of the JIRA ticket to the PR title (e.g. "feat: new shiny feature [MTT-123]") --> [MTTB-1278](https://jira.unity3d.com/browse/MTTB-1273) fixes: #3418 ## Changelog - Added: A `ScenePath` field on the `SceneEvent` returned by the `OnSceneEvent` callback. - Fixed: Various bugs around the `OnSceneEvent` callback. ## Testing and Documentation - Includes unit tests. <!-- Uncomment and mark items off with a * if this PR deprecates any API: ### Deprecated API - [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter yyyy-mm-dd)` entry. - [ ] An [api updater] was added. - [ ] Deprecation of the API is explained in the CHANGELOG. - [ ] The users can understand why this API was removed and what they should use instead. --> ## Backport <!-- If this is a backport: - Add the following to the PR title: "\[Backport\] ..." . - Link to the original PR. If this needs a backport - state this here If a backport is not needed please provide the reason why. If the "Backports" section is not present it will lead to a CI test failure. --> This is a backport of #3458 --------- Co-authored-by: Noel Stephens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTTB-1278
fixes: #3418
Changelog
ScenePathfield on theSceneEventreturned by theOnSceneEventcallback.OnSceneEventcallback.Testing and Documentation
Backport
Backported by #3487