zip-create: await zip writing before ending tasks #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `createZip` function, called for each chunk, is asynchronous. While `createZip` calls are correctly awaited within `Promise.all()`, the internal call to `fsUtils.zip.write` is not awaited. This function is also asynchronous: https://github.com/TryGhost/migrate/blob/7686d2d3be174fde8ebbc78699aa7b3e7b89d7e4/packages/mg-fs-utils/lib/zip.js#L57 This omission caused the Zipping chunks task to exit prematurely, without waiting the end of zip file creation. With this fix the comment is not needed and the cleanup task can be re-activated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
createZipfunction, called for each chunk, is asynchronous. WhilecreateZipcalls are correctly awaited withinPromise.all(), the internal call tofsUtils.zip.writeis not awaited. This function is also asynchronous:https://github.com/TryGhost/migrate/blob/7686d2d3be174fde8ebbc78699aa7b3e7b89d7e4/packages/mg-fs-utils/lib/zip.js#L57
This omission caused the Zipping chunks task to exit prematurely, without waiting the end of zip file creation.
With this fix the comment is not needed and the cleanup task can be re-activated.