Skip to content

zip-create: await zip writing before ending tasks #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

zip-create: await zip writing before ending tasks #615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions tasks/zip-create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ async function createZip(chunk, index, ctx) {
const zipFileParts = parse(ctx.args.dirPath);
const zipName = `${zipFileParts.name}_${index}.zip`;

fsUtils.zip.write(ctx.fileCache.zipDir, chunk, zipName);
await fsUtils.zip.write(ctx.fileCache.zipDir, chunk, zipName);
}

const initialise = (options) => {
Expand Down Expand Up @@ -157,8 +157,6 @@ const getFullTaskList = (options) => {
try {
let chunkDirs = globSync(`${ctx.fileCache.zipDir}/chunks/*`);

// This does not work properly, and is still trying to create the zip file when the tmp dir has been deleted
// When resolved, re-enable the 'Cleaning up' task
await Promise.all(chunkDirs.map((dir, index) => {
return createZip(dir, index, ctx);
}));
Expand Down Expand Up @@ -190,7 +188,6 @@ const getFullTaskList = (options) => {
},
{
title: 'Cleaning up',
skip: () => true,
task: async (ctx) => {
// 7. Remove the cached data
try {
Expand Down