Skip to content

Review of fldigixmlrpc code #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

Review of fldigixmlrpc code #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9e7014b
reset connerr in fldigi_toggle()
zcsahok Feb 11, 2025
44c23be
wait a bit after :FLDigi in changepars.c
zcsahok Feb 11, 2025
7e2def2
move 'xmlrpc_env env' to fldigi_xmlrpc_init()
zcsahok Feb 11, 2025
19954f8
use xmlrpc_release() for both failed init and cleanup
zcsahok Feb 11, 2025
38d0ad6
extend xmlrpc_res_init() and use it in fldigi_xmlrpc_query()
zcsahok Feb 11, 2025
8f5d757
earlier exit from fldigi_xmlrpc_query() if not use_fldigi
zcsahok Feb 11, 2025
2826d03
extract build_param_array() from fldigi_xmlrpc_query()
zcsahok Feb 12, 2025
1c129d3
use constant from xmlrpc lib
zcsahok Feb 12, 2025
5b69ddf
take early exit on connerr
zcsahok Feb 12, 2025
84e11c5
use own xmlrpc_env in fldigi_xmlrpc_query()
zcsahok Feb 12, 2025
b585d55
return error on failed init
zcsahok Feb 12, 2025
bac6f18
allow void call for fldigi_xmlrpc_query()
zcsahok Feb 12, 2025
d9c5f3f
reduce indent in fldigi_get_log_call() and fldigi_get_log_serial_numb…
zcsahok Feb 12, 2025
623d89c
astyle
zcsahok Feb 12, 2025
f3e905e
fix building without fldigixmlrpc
zcsahok Feb 12, 2025
171ec74
extract parse_call_result()
zcsahok Feb 13, 2025
9052db1
fix compilation error
zcsahok Feb 13, 2025
1f36a46
switch to "private" xmlrpc client mode
zcsahok Feb 16, 2025
3fd8e8b
switch to standard XML-RPC format specification
zcsahok Feb 16, 2025
f7fb77d
make mutexes static
zcsahok Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/changepars.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,12 +650,12 @@ int changepars(void) {
case 51: { /* FLDIGI - turn on/off */
if (digikeyer == FLDIGI) {
if (fldigi_toggle()) {
fldigi_clear_connerr();
mvaddstr(13, 29, "FLDIGI ON");
} else {
mvaddstr(13, 29, "FLDIGI OFF");
}
refreshp();
sleep(1);
}
break;
}
Expand Down
Loading
Loading