Review of fldigixmlrpc code #467
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after a toggle we shall start from a fresh state no extra method is needed as this is done implicitly in changepars refreshbp can be dropped, it's done later in the code
in order to see the current setting
it is used there locally for error reporting
in order to reduce complexity also check DECREFs
to reduce indentation
used for internal error reporting anyway, no need to pass it by the caller
and use xmlrpc_res_free() to free result
dl1jbe
reviewed
Feb 14, 2025
The problem is that the xmlrpc_client_call_server_params() or other function using the "global" client mode return a non-initialized result pointer (a local variable containing garbage) in case of some error situations. This makes impossible to decide whether the result should be free'd or not. The xmlrpc documentation contains no hint on this. The "private" functions on the other can use a pointer passed by the caller, so in this case if the initial NULL is untouched then it hasn't been allocated yet, hence no free'ing is needed.
|
Documentation references: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A review/rework of Fldigi interworking. It started as I couldn't get the idea behind
connerrandconnerrcntleading to reconnection, at least this is stated in the comment (maybe @airween knows it). Then a number of issues popped up, I'm working through them slowly. Hopefully will get some of the issues from #463 fixed.