Skip to content

[ZH] Fix crashing within AIPathfind due to inadequate cleanup of pathfindinfo resources. #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

[ZH] Fix crashing within AIPathfind due to inadequate cleanup of pathfindinfo resources. #994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
add0ba6
[ZH] Reduce crashing within AIPathfind due to inadequate pathing reso…
Mauller Jun 1, 2025
de665de
[ZH] Add more places to prevent cells leaking pathing info if they fa…
Mauller Jun 2, 2025
140e180
[ZH] Reorder cells cleanup so cell lists are cleared before the indiv…
Mauller Jun 5, 2025
ac23a95
Fix m_open incorrectly being initialized to true in startPathFind
Jun 7, 2025
982dd47
[ZH] Add extra allocateInfo checks within internal_findHierarchicalPa…
Mauller Jun 8, 2025
07b5161
[ZH] Scuff the Pathing so it runs like retail before getting caught i…
Mauller Jun 10, 2025
54828e3
[ZH] Catch dangling parent cell crash in PathfindCell::costSoFar()
Mauller Jun 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions GeneralsMD/Code/GameEngine/Include/GameLogic/AIPathfind.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
//#include "GameLogic/Locomotor.h" // no, do not include this, unless you like long recompiles
#include "GameLogic/LocomotorSet.h"
#include "GameLogic/GameLogic.h"
#include "Common/GameDefines.h"

class Bridge;
class Object;
Expand All @@ -50,6 +51,10 @@ class PathfindZoneManager;

#define INFANTRY_MOVES_THROUGH_INFANTRY

// TheSuperHackers @info This is here to easily toggle the retail compatible hacks for the pathfinding
#if RETAIL_COMPATIBLE_CRC
#define RETAIL_COMPATIBLE_PATHFINDING (1)
#endif

typedef UnsignedShort zoneStorageType;

Expand Down Expand Up @@ -208,6 +213,9 @@ class PathfindCellInfo
{
friend class PathfindCell;
public:
#if RETAIL_COMPATIBLE_PATHFINDING
static void forceCleanPathFindInfoCells(void);
#endif
static void allocateCellInfos(void);
static void releaseCellInfos(void);

Expand Down Expand Up @@ -699,6 +707,9 @@ class Pathfinder : PathfindServicesInterface, public Snapshot
Path *getDebugPath( void );
void setDebugPath( Path *debugpath );

#if RETAIL_COMPATIBLE_PATHFINDING
void forceCleanCells(void);
#endif
void cleanOpenAndClosedLists(void);

// Adjusts the destination to a spot near dest that is not occupied by other units.
Expand Down
Loading
Loading