OpenAL support #784
Draft
OpenAL support #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feliwir
force-pushed
the
openal-support
branch
3 times, most recently
from
b2c6d57 to
8d58e1d
Compare
Mauller
reviewed
May 6, 2025
GeneralsMD/Code/GameEngineDevice/Source/MilesAudioDevice/MilesAudioFileCache.h
Outdated
Show resolved
Hide resolved
feliwir
force-pushed
the
openal-support
branch
4 times, most recently
from
65fcd91 to
68cd907
Compare
Mauller
reviewed
May 8, 2025
Mauller
reviewed
May 8, 2025
GeneralsMD/Code/GameEngineDevice/Include/MilesAudioDevice/MilesAudioManager.h
Show resolved
Hide resolved
Mauller
reviewed
May 8, 2025
GeneralsMD/Code/GameEngineDevice/Include/Win32Device/Common/Win32GameEngine.h
Outdated
Show resolved
Hide resolved
Mauller
reviewed
May 8, 2025
GeneralsMD/Code/GameEngineDevice/Source/MilesAudioDevice/MilesAudioFileCache.h
Show resolved
Hide resolved
Mauller
reviewed
May 8, 2025
GeneralsMD/Code/GameEngineDevice/Source/VideoDevice/FFmpeg/FFmpegVideoPlayer.cpp
Outdated
Show resolved
Hide resolved
Mauller
reviewed
May 8, 2025
GeneralsMD/Code/GameEngineDevice/Source/OpenALDevice/OpenALAudioFileCache.h
Show resolved
Hide resolved
|
In terms of functionality this should be complete now. I'll move some of the duplicated parts to FFmpegOpenALAudioStream, but maybe someone else can test the functionality already |
aliendroid1
reviewed
Jul 27, 2025
| @@ -0,0 +1,37 @@ | |||
| /* | |||
| ** Command & Conquer Generals Zero Hour(tm) | |||
| ** Copyright 2025 Electronic Arts Inc. | |||
There was a problem hiding this comment.
I think it would be better to remove these two copyright lines as this is completely new code written by you and should be under superhackers' copyright or yours
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.