[ZH] Linux tools compilation #620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feliwir
force-pushed
the
linux
branch
3 times, most recently
from
ea5ce04 to
83577e1
Compare
xezon
reviewed
Apr 7, 2025
GeneralsMD/Code/CMakeLists.txt
Outdated
| @@ -24,6 +25,10 @@ target_include_directories(zi_libraries_source_wwvegas_wwlib INTERFACE "Librarie | |||
| target_include_directories(zi_libraries_source_wwvegas_wwmath INTERFACE "Libraries/Source/WWVegas/WWMath") | |||
| target_include_directories(zi_libraries_source_wwvegas_wwsaveload INTERFACE "Libraries/Source/WWVegas/WWSaveLoad") | |||
| target_include_directories(zi_main INTERFACE "Main") | |||
| target_link_libraries(zi_utility INTERFACE | |||
There was a problem hiding this comment.
Perhaps give this a different name because it is too easy to confuse it with gz_utility. Perhaps call it zi_always if it is linked in all targets?
There was a problem hiding this comment.
I think we should rename all gz_ targets, since it is misleading. Not sure if it should be part of this PR
There was a problem hiding this comment.
Should be separate change yes. I also put some notes into your cmake skeleton change about that.
|
I think, I have found more elegant alternative to (I have used custom makefile when doing mingw fixes, so I have not ran into this earlier.) |
feliwir
force-pushed
the
linux
branch
2 times, most recently
from
79ea21e to
0e4bdf7
Compare
feliwir
force-pushed
the
linux
branch
2 times, most recently
from
bc7f00d to
2f581cb
Compare
Co-authored-by: Patrick Zacharias <[email protected]>
Co-authored-by: Patrick Zacharias <[email protected]>
Co-authored-by: Patrick Zacharias <[email protected]>
feliwir
added a commit
that referenced
this pull request
Apr 8, 2025
Co-authored-by: Patrick Zacharias <[email protected]>
feliwir
added a commit
that referenced
this pull request
Apr 8, 2025
Co-authored-by: Patrick Zacharias <[email protected]>
feliwir
added a commit
that referenced
this pull request
Apr 8, 2025
Co-authored-by: Patrick Zacharias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stripped down variant of #522