Skip to content

[GEN][ZH] Fix black terrain in World Builder without RTS_DEBUG #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

xezon
Copy link

@xezon xezon commented Jun 24, 2025

This change fixes the black terrain in World Builder without RTS_DEBUG. This issue happens because all code around GlobalData::m_shroudOn is compiled out without RTS_DEBUG, which enables shroud and turns the world black.

TODO

@xezon xezon added this to the Major bug fixes milestone Jun 24, 2025
@xezon xezon added Major Severity: Minor < Major < Critical < Blocker WorldBuilder Relates to World Builder Fix Is fixing something, but is not user facing labels Jun 24, 2025
@xezon xezon force-pushed the xezon/fix-black-terrain branch from 4455050 to c369e8e Compare June 24, 2025 20:32
@Caball009
Copy link

This fix works as intended for me.

@xezon xezon force-pushed the xezon/fix-black-terrain branch from c369e8e to d204b44 Compare June 28, 2025 17:17
@xezon
Copy link
Author

xezon commented Jun 28, 2025

Rebased on latest main.

@xezon xezon requested a review from a team June 29, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Is fixing something, but is not user facing Major Severity: Minor < Major < Critical < Blocker WorldBuilder Relates to World Builder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terrain renders black in World Builder [ZH] World Builder behaves differently when built with RTS_BUILD_OPTION_DEBUG enabled
2 participants