Skip to content

[GEN][ZH] Fix inaudible UnableToSetRallyPoint audio event when misplacing a Rally Point #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Stubbjax
Copy link

The UnableToSetRallyPoint audio event cannot be heard because its player index is unassigned. This is now rectified and the logic matches the RallyPointSet audio event. This is a user-facing change - the player will now correctly hear the 'invalid action' sound when a rally point placement fails, similarly to when a building placement fails.

Audio events that do not specify an owning player are not expected to be valid.

if (owningPlayer == NULL) {
    DEBUG_CRASH(("Sound '%s' expects an owning player, but the audio event that created it didn't specify one.\n", ei->m_audioName.str()));
    return FALSE;
}

@Mauller Mauller added Audio Is audio related Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour labels Jun 23, 2025
@xezon xezon added the Bug Something is not working right, typically is user facing label Jun 23, 2025
@xezon
Copy link

xezon commented Jun 23, 2025

Nice. Could you perhaps attach a video? Would be interest to hear that.

Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@xezon xezon changed the title [GEN][ZH] Assign missing player index to the unable-to-set-rally-point audio event [GEN][ZH] Fix missing UnableToSetRallyPoint audio event when misplacing a Rally Point Jun 25, 2025
@xezon
Copy link

xezon commented Jun 25, 2025

Title text improved.

@xezon xezon changed the title [GEN][ZH] Fix missing UnableToSetRallyPoint audio event when misplacing a Rally Point [GEN][ZH] Fix inaudible UnableToSetRallyPoint audio event when misplacing a Rally Point Jun 25, 2025
@xezon xezon merged commit d582e77 into TheSuperHackers:main Jun 25, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audio Is audio related Bug Something is not working right, typically is user facing Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker ZH Relates to Zero Hour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants