Skip to content

[GEN][ZH] Add TheSuperHackers version to options screen #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fbraz3
Copy link

@fbraz3 fbraz3 commented Jun 22, 2025

This complements PR #929 and its related to ISSUE #1010

What this PR does?

Reads the file next_tag.txt generated by ci process and add it to options screen.

If the file does not exists by the build process, GAME_VERSION variable will be set to a blank displaying only "TheSuperHackers" to the game version in options screen.

image

@Mauller Mauller added Minor Severity: Minor < Major < Critical < Blocker Build Anything related to building, compiling Gen Relates to Generals ZH Relates to Zero Hour labels Jun 23, 2025
@xezon xezon added the GUI For graphical user interface label Jun 23, 2025
@xezon
Copy link

xezon commented Jun 23, 2025

The CI version probably make sense for CI generated releases, but we will also need a version generated by commit number and hash. Code for that is linked in #1010

Also, perhaps it would be good to append version information to the Window Title. Maybe even print directly in the main menu with a transparent font to make it extra easy to see.

Because in the Options Menu it is kinda obscure, which can be missed by players, if asked for version information of their client.

@fbraz3
Copy link
Author

fbraz3 commented Jun 23, 2025

The CI version probably make sense for CI generated releases, but we will also need a version generated by commit number and hash. Code for that is linked in #1010

Also, perhaps it would be good to append version information to the Window Title. Maybe even print directly in the main menu with a transparent font to make it extra easy to see.

Because in the Options Menu it is kinda obscure, which can be missed by players, if asked for version information of their client.

I don't see any problem with adding the version info to the existing options menu. We just need to let players know, in the open issue form, that the version can be found there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Anything related to building, compiling Gen Relates to Generals GUI For graphical user interface Minor Severity: Minor < Major < Critical < Blocker ZH Relates to Zero Hour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants