[GEN][ZH] Fix missing unit voice when attacking the ground #1156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…through at switch case GameMessage::MSG_DO_FORCE_ATTACK_GROUND in pickAndPlayUnitVoiceResponse()
xezon
added
Audio
xezon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the missing unit voice when attacking the ground due wrong fallthrough at switch case GameMessage::MSG_DO_FORCE_ATTACK_GROUND in pickAndPlayUnitVoiceResponse()
In the original game, units would not play their attack voice when attacking the ground, except for the USA Tomahawk because it uses the VoiceBombard audio.
This issue is caused by a wrong switch case setup. It was introduced by an original developer who incorrectly added the
case GameMessage::MSG_SWITCH_WEAPONSbetween the caseGameMessage::MSG_DO_FORCE_ATTACK_GROUNDandcase GameMessage::MSG_DO_FORCE_ATTACK_OBJECT.Fixed attack audio
generalszh.2025-06-22.10-15-04-70.mp4