[GEN][ZH] Remove unnecessary NULL pointer tests in RTS3DScene::RTS3DScene()

[xezon]

This change removes unnecessary NULL pointer tests in RTS3DScene::RTS3DScene() to make the compiler happy.

Instead I added tests for the array sizes and only allocate the arrays when the value is larger than 0, which is currently always the case anyway. This does not change game behaviour.

GeneralsMD\Code\GameEngineDevice\Source\W3DDevice\GameClient\W3DScene.cpp(174): warning C6011: Dereferencing NULL pointer 'TheWritableGlobalData'.

[roossienb]

While it works, this is not the right solution. An empty array is still a valid array (and can be accessed), while a null-pointer cannot be accessed.

There are no null-pointer checks when these arrays are being accessed, so a crash risk is introduced.

Imho the correct solution is to remove the NULL initialization of the arrays. Those are not needed, as they get overwritten by the array creation a few lines below.

[xezon]

Yes a 0 sized array is possible to allocate, but it is useless. It cannot be dereferenced.

My understanding of this code is that if the size was 0, then it would not be dereferencing the arrays.

Example:

RenderObjClass **occluderList=m_potentialOccluders; // Would be NULL
for (k=0; k<m_numPotentialOccluders; k++) // Would not enter the loop, because 0<0 is false.
{
	renderOneObject(rinfo, (*occluderList), localPlayerIndex);
	occluderList++;	//advance to next one
}

Can you show the code that you think would be unsafe if array size was 0?

[roossienb]

I checked and you are right. There are no places where this could be an issue