Skip to content

[GEN][ZH] Fix heap-use-after-free in DisconnectManager::update() #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[GEN][ZH] Fix heap-use-after-free in DisconnectManager::update() #1103

wants to merge 1 commit into from

Conversation

xezon
Copy link

@xezon xezon commented Jun 19, 2025

This change fixes a heap-use-after-free in DisconnectManager::update().

This problem would only happen in Online matches when the Disconnect Menu pops up.

GeneralsMD\Code\GameEngine\Source\GameNetwork\DisconnectManager.cpp(145): warning C26815: The pointer is dangling because it points at a temporary instance which was destroyed.

@xezon xezon added this to the Stability fixes milestone Jun 19, 2025
@xezon xezon added Bug Something is not working right, typically is user facing Major Severity: Minor < Major < Critical < Blocker Memory Is memory related labels Jun 19, 2025
@xezon xezon force-pushed the xezon/staticanalysis2/016 branch from 9982548 to f130ed8 Compare June 20, 2025 07:33
Mauller
Mauller approved these changes Jun 20, 2025
View reviewed changes
Copy link

@Mauller Mauller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mauller Mauller Mauller approved these changes

Assignees
No one assigned
Labels
Bug Something is not working right, typically is user facing Major Severity: Minor < Major < Critical < Blocker Memory Is memory related
Projects
None yet
Milestone
Stability fixes
Development

Successfully merging this pull request may close these issues.
2 participants
@xezon @Mauller