Skip to content

[GEN][ZH] Fix using uninitialized memory 'buff' in INI::getNextQuotedAsciiString() #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[GEN][ZH] Fix using uninitialized memory 'buff' in INI::getNextQuotedAsciiString() #1097

wants to merge 1 commit into from

Conversation

xezon
Copy link

@xezon xezon commented Jun 19, 2025

This change fixes using uninitialized memory 'buff' in INI::getNextQuotedAsciiString() and makes the compiler happy.

It appears to be a theoretical issue only.

GeneralsMD\Code\GameEngine\Source\Common\INI\INI.cpp(752): warning C6054: String 'buff' might not be zero-terminated.
GeneralsMD\Code\GameEngine\Source\Common\INI\INI.cpp(752): warning C6001: Using uninitialized memory 'buff'.

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Fix Is fixing something labels Jun 19, 2025
@xezon xezon force-pushed the xezon/staticanalysis2/012 branch from b6e5a8f to 4d7e026 Compare June 20, 2025 07:32
@roossienb
Copy link

Wouldn't char buff[INI_MAX_CHARS_PER_LINE] = {0}; be a cleaner solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Fix Is fixing something Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xezon @roossienb