Skip to content

[GEN][ZH] Prevent unlikely buffer overrun while writing to 'newPts' in PolygonTrigger::reallocate() #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xezon
Copy link

@xezon xezon commented Jun 19, 2025

This change prevents an unlikely buffer overrun while writing to 'newPts' in PolygonTrigger::reallocate() and makes the compiler happy.

GeneralsMD\Code\GameEngine\Source\GameLogic\Map\PolygonTrigger.cpp(105): warning C6386: Buffer overrun while writing to 'newPts':  the writable size is 'm_sizePoints*12' bytes, but '24' bytes might be written.

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Fix Is fixing something labels Jun 19, 2025
@xezon xezon force-pushed the xezon/staticanalysis2/006 branch from a4b8323 to a9fd1d2 Compare June 20, 2025 07:31
@Caball009
Copy link

What warning settings are required to get a warning here? I can't replicate it, nor do I really understand what the warning is about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Is fixing something Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants