Skip to content

[GEN][ZH] Prevent using uninitialized memory 'offset_u' in W3DTankDraw, W3DTankTruckDraw #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −4
Open

[GEN][ZH] Prevent using uninitialized memory 'offset_u' in W3DTankDraw, W3DTankTruckDraw #1086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/Drawable/Draw/W3DTankDraw.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,12 @@ void W3DTankDraw::updateTreadPositions(Real uvDelta)
else
if (pTread->m_type == TREAD_RIGHT) //this tread needs to scroll backwards
offset_u = pTread->m_materialSettings.customUVOffset.X - uvDelta;

else
{
DEBUG_CRASH(("Unhandled case in W3DTankDraw::updateTreadPositions"));
offset_u = 0.0f;
}

// ensure coordinates of offset are in [0, 1] range:
offset_u = offset_u - WWMath::Floor(offset_u);
pTread->m_materialSettings.customUVOffset.Set(offset_u,0);
Expand Down
7 changes: 6 additions & 1 deletion ...rals/Code/GameEngineDevice/Source/W3DDevice/GameClient/Drawable/Draw/W3DTankTruckDraw.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,12 @@ void W3DTankTruckDraw::updateTreadPositions(Real uvDelta)
else
if (pTread->m_type == TREAD_RIGHT) //this tread needs to scroll backwards
offset_u = pTread->m_materialSettings.customUVOffset.X - uvDelta;

else
{
DEBUG_CRASH(("Unhandled case in W3DTankTruckDraw::updateTreadPositions"));
offset_u = 0.0f;
}

// ensure coordinates of offset are in [0, 1] range:
offset_u = offset_u - WWMath::Floor(offset_u);
pTread->m_materialSettings.customUVOffset.Set(offset_u,0);
Expand Down
7 changes: 6 additions & 1 deletion GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameClient/Drawable/Draw/W3DTankDraw.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,12 @@ void W3DTankDraw::updateTreadPositions(Real uvDelta)
else
if (pTread->m_type == TREAD_RIGHT) //this tread needs to scroll backwards
offset_u = pTread->m_materialSettings.customUVOffset.X - uvDelta;

else
{
DEBUG_CRASH(("Unhandled case in W3DTankDraw::updateTreadPositions"));
offset_u = 0.0f;
}

// ensure coordinates of offset are in [0, 1] range:
offset_u = offset_u - WWMath::Floor(offset_u);
pTread->m_materialSettings.customUVOffset.Set(offset_u,0);
Expand Down
7 changes: 6 additions & 1 deletion ...lsMD/Code/GameEngineDevice/Source/W3DDevice/GameClient/Drawable/Draw/W3DTankTruckDraw.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,12 @@ void W3DTankTruckDraw::updateTreadPositions(Real uvDelta)
else
if (pTread->m_type == TREAD_RIGHT) //this tread needs to scroll backwards
offset_u = pTread->m_materialSettings.customUVOffset.X - uvDelta;

else
{
DEBUG_CRASH(("Unhandled case in W3DTankTruckDraw::updateTreadPositions"));
offset_u = 0.0f;
}

// ensure coordinates of offset are in [0, 1] range:
offset_u = offset_u - WWMath::Floor(offset_u);
pTread->m_materialSettings.customUVOffset.Set(offset_u,0);
Expand Down
Loading