[GEN][ZH] Annotate fallthrough between various switch case labels #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Minor
xezon
force-pushed
the
xezon/staticanalysis/001
branch
from
812d386 to
d88e895
Compare
Mauller
approved these changes
Jun 20, 2025
| case CHINA_FRIEND: | ||
| side.set("China"); | ||
| break; | ||
| case GLA_ENEMY: | ||
| isFriend = FALSE; | ||
| isFriend = FALSE; |
There was a problem hiding this comment.
Seems odd that it thinks there was a change here.
There was a problem hiding this comment.
Seems odd that it thinks there was a change here.
There's a tab after it in the original line.
Comment on lines
941
to
942
| case SCORESCALEUPTRANSITION_2: | ||
| case SCORESCALEUPTRANSITION_3: |
There was a problem hiding this comment.
I am surprised it does not warn about these cases falling through.
Comment on lines
+642
to
644
| FALLTHROUGH; | ||
| case 2: | ||
| break; |
There was a problem hiding this comment.
State is not used outside of this function so this seems a bit redundant, case 2 could be removed and a break added at the end of case 1.
Comment on lines
+145
to
148
| FALLTHROUGH; | ||
|
|
||
| case FLASHTRANSITION_FADE_IN_2: | ||
| case FLASHTRANSITION_FADE_IN_3: |
There was a problem hiding this comment.
Same as the score scaleup, im surprised it does not complain here, unless it just optimises away empty cases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change annotates fallthroughs in GameEngine to suppress warnings and make the intent clear.