[CORE][GEN][ZH] Add missing virtual destructors for virtual classes #1049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some virtual classes have no virtual destructor, which leads to compiler warnings when an object of such a class is manually deleted:
delete called on non-final 'Class' that has virtual functions but non-virtual destructor [-Wdelete-non-abstract-non-virtual-dtor]
destructor called on non-final 'Class' that has virtual functions but non-virtual destructor [-Wdelete-non-abstract-non-virtual-dtor]
If it helps with the review process, I could provide a list with class name + filename + line number where the delete happens / the compiler warnings originate. I can also provide that in the form of an url.