[GEN][ZH] Re-initialize pathfinding information cells into a known state in Pathfinder::reset() #1037
Conversation
…ate in Pathfinder::reset()
Mauller
added
Minor
| @@ -3460,6 +3468,9 @@ void Pathfinder::reset( void ) | |||
| m_wallHeight = 0.0f; | |||
| } | |||
| m_zoneManager.reset(); | |||
|
|
|||
| // TheSuperHackers @fix Mauller 09/06/2025 Re-initialize pathfinding cell info objects so they are in a known clean state | |||
| PathfindCellInfo::initializeCellInfos(); | |||
There was a problem hiding this comment.
Can you explain what exactly this achieves?
I see in debugger the main effect it has is putting the cell links into linear order again. But what is the effective consequence if the links were shuffled after one map run? Would there be a performance degradation?
There was a problem hiding this comment.
i meant to put this up as a draft as i came across any other stuff.
This bit alone was to just put things into a known good state in case any pathfinding info cells were left dangling.
There was a problem hiding this comment.
I added a counter to PathfindCellInfo::getACellInfo, PathfindCellInfo::releaseACellInfo and saw that its usage returned to 0 on map reset. I suggest to add this in debug builds and assert on that condition.
Just a simple tweak, very minimal on the surface, but it's just to keep the initial state of the pathfinding information cells consistent between games.