Skip to content

[CMAKE] Remove obsolete interface libraries, add missing core gameengine include interface library #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xezon
Copy link

@xezon xezon commented Jun 9, 2025

This change removes a bunch of obsolete interface libraries and adds a missing core gameengine include interface library that is needed for the ParticleEditor (and WWDownload when Common/Debug.h is moved).

@xezon xezon added this to the Code foundation build up milestone Jun 9, 2025
@xezon xezon requested a review from OmniBlade June 9, 2025 11:34
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Build Anything related to building, compiling labels Jun 9, 2025
@xezon xezon requested a review from a team June 13, 2025 10:19
Copy link

@aliendroid1 aliendroid1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of adding corei_gameengine_include into so many places just for debug.h, it would be better to just move debug.h to utilities since its an independent header

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Anything related to building, compiling Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants