[GEN][ZH] Downgrade debug assertion to log for isPathInDirectory (#1128)

Author: slurmlord

Generals/Code/GameEngine/Source/Common/System/FileSystem.cpp

@@ -367,7 +367,6 @@ Bool FileSystem::isPathInDirectory(const AsciiString& testPath, const AsciiStrin
 	if (!testPathNormalized.startsWith(basePathNormalized))
 #endif
 	{
-		DEBUG_CRASH(("Normalized file path for '%s': '%s' was outside the expected base path of '%s' (normalized: '%s').\n", testPath.str(), testPathNormalized.str(), basePath.str(), basePathNormalized.str()));
 		return false;
 	}
 

Generals/Code/GameEngine/Source/Common/System/SaveGame/GameState.cpp

@@ -936,6 +936,7 @@ AsciiString GameState::portableMapPathToRealMapPath(const AsciiString& in) const
 
 	if (!FileSystem::isPathInDirectory(prefix, containingBasePath))
 	{
+		DEBUG_LOG(("Normalized file path for '%s' was outside the expected base path of '%s'.\n", prefix.str(), containingBasePath.str()));
 		return AsciiString::TheEmptyString;
 	}
 

GeneralsMD/Code/GameEngine/Source/Common/System/FileSystem.cpp

@@ -384,7 +384,6 @@ Bool FileSystem::isPathInDirectory(const AsciiString& testPath, const AsciiStrin
 	if (!testPathNormalized.startsWith(basePathNormalized))
 #endif
 	{
-		DEBUG_CRASH(("Normalized file path for '%s': '%s' was outside the expected base path of '%s' (normalized: '%s').\n", testPath.str(), testPathNormalized.str(), basePath.str(), basePathNormalized.str()));
 		return false;
 	}
 

GeneralsMD/Code/GameEngine/Source/Common/System/SaveGame/GameState.cpp

@@ -936,6 +936,7 @@ AsciiString GameState::portableMapPathToRealMapPath(const AsciiString& in) const
 
 	if (!FileSystem::isPathInDirectory(prefix, containingBasePath))
 	{
+		DEBUG_LOG(("Normalized file path for '%s' was outside the expected base path of '%s'.\n", prefix.str(), containingBasePath.str()));
 		return AsciiString::TheEmptyString;
 	}