[GEN][ZH] Replace TheGlobalData macro with inline variable to make debugging easier (#1118)

Author: xezon

Generals/Code/GameEngine/Include/Common/GlobalData.h

@@ -560,6 +560,11 @@ class GlobalData : public SubsystemInterface
 // singleton
 extern GlobalData* TheWritableGlobalData;
 
+// use TheGlobalData for all read-only accesses
+#if __cplusplus >= 201703L
+inline const GlobalData* const& TheGlobalData = TheWritableGlobalData;
+#else
 #define TheGlobalData ((const GlobalData*)TheWritableGlobalData)
+#endif
 
 #endif

GeneralsMD/Code/GameEngine/Include/Common/GlobalData.h

@@ -573,6 +573,11 @@ class GlobalData : public SubsystemInterface
 // singleton
 extern GlobalData* TheWritableGlobalData;
 
+// use TheGlobalData for all read-only accesses
+#if __cplusplus >= 201703L
+inline const GlobalData* const& TheGlobalData = TheWritableGlobalData;
+#else
 #define TheGlobalData ((const GlobalData*)TheWritableGlobalData)
+#endif
 
 #endif