Skip to content

Commit 2a179d8

Browse files
authored
[ZH] Fix heap-use-after-free in LayersList::updateUIFromList() when creating a new map in World Builder (#1098)
1 parent cc7dbee commit 2a179d8

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

GeneralsMD/Code/Tools/WorldBuilder/src/WorldBuilderDoc.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1271,14 +1271,16 @@ BOOL CWorldBuilderDoc::OnNewDocument()
12711271
m_waypointTableNeedsUpdate = true;
12721272
m_curWaypointID = 0;
12731273
WbApp()->selectPointerTool();
1274-
PolygonTrigger::deleteTriggers();
12751274

12761275
// Make sure that all the old units are removed from the list.
12771276
// Bug fix by MLL 1/14/03
12781277
TheLayersList->enableUpdates();
12791278
TheLayersList->resetLayers();
12801279
TheLayersList->disableUpdates();
12811280

1281+
// TheSuperHackers @bugfix Caball009 20/06/2025 Must not delete polygon triggers before calling enableUpdates.
1282+
PolygonTrigger::deleteTriggers();
1283+
12821284
TheSidesList->clear();
12831285
TheSidesList->validateSides();
12841286

0 commit comments

Comments
 (0)