Skip to content

refactor(CubeProxy): remove unused faulty_backend_set check #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
novahe wants to merge 1 commit into from
Closed

refactor(CubeProxy): remove unused faulty_backend_set check #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 1 addition & 29 deletions CubeProxy/lua/utils.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,38 +53,10 @@ end
function _M.is_faulty_backend(self, backend_ip, check_remote)
local cache = ngx.shared.faulty_backend
local value = cache:get(backend_ip)
if not value or value ~= "true" then
return false, nil
end

if check_remote == false then
if value == "true" then
Copy link
Copy Markdown
Collaborator

@chenhengqi chenhengqi May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove the entire is_faulty_backend() and ngx.shared.faulty_backend?

return true, nil
end

local redis = require "redis_iresty"
local red = redis:new({
redis_ip = ngx.var.redis_ip,
redis_port = ngx.var.redis_port,
redis_pd = ngx.var.redis_pd,
redis_index = ngx.var.redis_index
})
local key = "faulty_backend_set"
local err
value, err = red:smembers(key)
if err then
return false, err
end

if not value then
return false, nil
end

for _, v in ipairs(value) do
if v == backend_ip then
return true, nil
end
end

return false, nil
end

Expand Down
Loading