refactor(CubeProxy): remove unused faulty_backend_set check#139
Closed
novahe wants to merge 1 commit into
Closed
Conversation
novahe
requested review from
chenhengqi,
fslongjin,
ls-ggg,
tinklone and
up2wing
as code owners
chenhengqi
reviewed
May 6, 2026
| local err | ||
| value, err = red:smembers(key) | ||
|
|
||
| local res, err = red:sismember("faulty_backend_set", backend_ip) |
Collaborator
There was a problem hiding this comment.
This faulty_backend_set set is never filled in our open source release. This can be removed completely instead.
novahe
changed the title
The faulty_backend_set in Redis is never filled in the open-source release. This change removes the unnecessary Redis lookup and relies solely on the local shared cache for faulty backend detection. Autonomously-by: Antigravity:Gemini-3-Flash
novahe
force-pushed
the
feat/optimize-healthcheck
branch
from
0d6c2b8 to
e9822c8
Compare
chenhengqi
reviewed
May 6, 2026
| end | ||
|
|
||
| if check_remote == false then | ||
| if value == "true" then |
Collaborator
There was a problem hiding this comment.
Why not remove the entire is_faulty_backend() and ngx.shared.faulty_backend?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(CubeProxy): remove unused faulty_backend_set check
ef: #135 (comment)